close
Skip to content

Interactivity API page restoring breaks embedded SPA apps with routing #60455

@esamattis

Description

@esamattis

Description

Interactivity API forces a page reload when it sees an unknown page for its pages cache in the popstate event.

The relevant code is here

// Listen to the back and forward buttons and restore the page if it's in the
// cache.
window.addEventListener( 'popstate', async () => {
const pagePath = getPagePath( window.location ); // Remove hash.
const page = pages.has( pagePath ) && ( await pages.get( pagePath ) );
if ( page ) {
renderRegions( page );
// Update the URL in the state.
state.url = window.location.href;
} else {
window.location.reload();
}
} );

This unfortunately breaks navigation in many single-page apps embedded in WordPress that use routers which manipulate the URL using the browser History API. For example search views commonly save the search filters to the query string using it. This happens for example with React and React Router when using the BrowserRouter. But I believe this affects any framework using the History API (Vue, Svelte, Solid, Angular etc.) and any manual History API usage.

This is unfortunate because it discards any state the SPA app might have. Like text typed in a textarea etc.

Not sure how this should be fixed. Maybe a hook which could be used to prevent the reloads on certain cases. For example we could store a flag to history.state and skip the reload based on that.

Step-by-step reproduction instructions

  1. Go to any WordPress site with the Interactivity API
  2. Open devtools and type history.pushState({}, "", "?ding=dong");
  3. Press the browser back button
  4. Press the browser forward button

The browser unexpectedly reloads the page because an url with ?ding=dong is emitted from the popstate event which is not in the pages cache.

Screenshots, screen recording, code snippet

No response

Environment info

Using WordPress 6.4.2 and Gutenberg bundled with it. This affects any newer versions as well because the same code is in trunk.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

Metadata

Metadata

Assignees

No one assigned

    Labels

    [Feature] Interactivity APIAPI to add frontend interactivity to blocks.[Type] BugAn existing feature does not function as intended

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions