std: migrate all fs APIs to Io #30232

Merged

andrewrk merged 195 commits from std.Io-fs into master 2025-12-27 14:10:53 +01:00

Conversation 6 Commits 195 Files changed 279 +20209 -18550

andrewrk commented 2025-12-20 05:55:36 +01:00

Owner

Copy link

This branch deletes std.fs.File in favor of std.Io.File and std.fs.Dir in favor of std.Io.Dir, as well as moving almost all std.fs API into std.Io.Dir.

The main purpose is to integrate file system I/O with the std.Io interface, which is a major part of #30150.

I also took advantage of the breakage to rename a number of file system APIs for consistency.

Upgrade Guide

Although it's a lot of breaking changes, unlike "writergate", this changeset is expected to be generally easy for Zig programmers to manage, because it does not require much critical thinking. For example, typical upgrade path will look something like this:

-file.close();
+file.close(io);

Although your upgrade diff might be large, it will be quite simple to understand what needs to be done.

Added:

• std.Io.Dir.hardLink
• std.Io.Dir.Reader
• std.Io.Dir.setFilePermissions
• std.Io.Dir.setFileOwner
• std.Io.File.NLink

Removed with no replacement:

• std.fs.realpathZ
• std.fs.realpathW
• std.fs.realpathW2
• std.fs.makeDirAbsoluteZ
• std.fs.deleteDirAbsoluteZ
• std.fs.openDirAbsoluteZ
• std.fs.renameAbsoluteZ
• std.fs.renameZ
• std.fs.deleteTreeAbsolute
• std.fs.symLinkAbsoluteW
• std.fs.Dir.realpathZ
• std.fs.Dir.realpathW
• std.fs.Dir.realpathW2
• std.fs.Dir.deleteFileZ
• std.fs.Dir.deleteFileW
• std.fs.Dir.deleteDirZ
• std.fs.Dir.deleteDirW
• std.fs.Dir.renameZ
• std.fs.Dir.renameW
• std.fs.Dir.symLinkWasi
• std.fs.Dir.symLinkZ
• std.fs.Dir.symLinkW
• std.fs.Dir.readLinkWasi
• std.fs.Dir.readLinkZ
• std.fs.Dir.readLinkW
• std.fs.Dir.adaptToNewApi
• std.fs.Dir.adaptFromNewApi
• std.fs.File.isCygwinPty
• std.fs.File.adaptToNewApi
• std.fs.File.adaptFromNewApi

Changed:

Many functions now have a std.Io parameter.

• std.fs.copyFileAbsolute -> std.Io.Dir.copyFileAbsolute

• std.fs.makeDirAbsolute -> std.Io.Dir.createDirAbsolute

• std.fs.deleteDirAbsolute -> std.Io.Dir.deleteDirAbsolute

• std.fs.openDirAbsolute -> std.Io.Dir.openDirAbsolute

• std.fs.openFileAbsolute -> std.Io.Dir.openFileAbsolute

• std.fs.accessAbsolute -> std.Io.Dir.accessAbsolute

• std.fs.createFileAbsolute -> std.Io.Dir.createFileAbsolute

• std.fs.deleteFileAbsolute -> std.Io.Dir.deleteFileAbsolute

• std.fs.renameAbsolute -> std.Io.Dir.renameAbsolute

• std.fs.readLinkAbsolute -> std.Io.Dir.readLinkAbsolute

• std.fs.symLinkAbsolute -> std.Io.Dir.symLinkAbsolute

• std.fs.has_executable_bit -> std.Io.File.Permissions.has_executable_bit

• std.fs.realpath -> std.Io.Dir.realPathFileAbsolute

• std.fs.rename -> std.Io.Dir.rename

• std.fs.cwd -> std.Io.Dir.cwd

• std.fs.defaultWasiCwd -> std.os.defaultWasiCwd

• std.fs.realpathAlloc -> std.Io.Dir.realPathFileAbsoluteAlloc

• std.fs.openSelfExe -> std.process.openExecutable

• std.fs.selfExePathAlloc -> std.process.executablePathAlloc

• std.fs.selfExePath -> std.process.executablePath

• std.fs.selfExeDirPath -> std.process.executableDirPath

• std.fs.selfExeDirPathAlloc -> std.process.executableDirPathAlloc

• std.fs.Dir.setAsCwd -> std.process.setCurrentDir

• std.fs.Dir.realpath -> std.Io.Dir.realPathFile

• std.fs.Dir.realpathAlloc -> std.Io.Dir.realPathFileAlloc

• std.fs.Dir -> std.Io.Dir

• std.fs.File -> std.Io.File

• std.fs.Dir.makeDir -> std.Io.Dir.createDir

• std.fs.Dir.makePath -> std.Io.Dir.createDirPath

• std.fs.Dir.makeOpenDir -> std.Io.Dir.createDirPathOpen

• std.fs.Dir.rename: now accepts two Dir parameters (plus Io)

• std.fs.Dir.atomicSymLink -> std.Io.Dir.symLinkAtomic

• std.fs.Dir.chmod -> std.Io.Dir.setPermissions

• std.fs.Dir.chown -> std.Io.Dir.setOwner

• std.fs.File.Mode -> std.Io.File.Permissions

• std.fs.File.PermissionsWindows -> std.Io.File.Permissions

• std.fs.File.PermissionsUnix -> std.Io.File.Permissions

• std.fs.File.default_mode -> std.Io.File.Permissions.default_file

• std.fs.File.getOrEnableAnsiEscapeSupport -> std.Io.File.enableAnsiEscapeCodes

• std.fs.File.setEndPos -> std.Io.File.setLength

• std.fs.File.getEndPos -> std.Io.File.length

• std.fs.File.seekTo, std.fs.File.seekBy, std.fs.File.seekFromEnd -> std.Io.File.Reader.seekTo, std.Io.File.Reader.seekBy, std.Io.File.Writer.seekTo

• std.fs.File.getPos -> std.Io.File.Reader.logicalPos, std.Io.Writer.logicalPos

• std.fs.File.mode() -> std.Io.File.stat().permissions.toMode

• std.fs.File.chmod -> std.Io.File.setPermissions

• std.fs.File.chown -> std.Io.File.setOwner

• std.fs.File.updateTimes -> std.Io.File.setTimestamps, std.Io.File.setTimestampsNow

• std.fs.File.read -> std.Io.File.readStreaming

• std.fs.File.readv -> std.Io.File.readStreaming

• std.fs.File.pread -> std.Io.File.readPositional

• std.fs.File.preadv -> std.Io.File.readPositional

• std.fs.File.preadAll -> std.Io.File.readPositionalAll

• std.fs.File.write -> std.Io.File.writeStreaming

• std.fs.File.writev -> std.Io.File.writeStreaming

• std.fs.File.pwrite -> std.Io.File.writePositional

• std.fs.File.pwritev -> std.Io.File.writePositional

• std.fs.File.writeAll -> std.Io.File.writeStreamingAll

• std.fs.File.pwriteAll -> std.Io.File.writePositionalAll

• std.fs.File.copyRange, std.fs.File.copyRangeAll -> std.Io.File.writer

Deprecated:

• std.fs.path -> std.Io.Dir.path
• std.fs.max_path_bytes -> std.Io.Dir.max_path_bytes
• std.fs.max_name_bytes -> std.Io.Dir.max_name_bytes

std.Progress Note

After updating your application that uses std.Progress:

-        const root_progress_node = std.Progress.start(.{
+        const root_progress_node = std.Progress.start(io, .{

Make sure you have defer root_progress_node.end(); there. Before, if control flow got to the end of main(), start code would exit all threads, including the std.Progress thread. Now, it is not a thread but a task, and you likely have defer threaded.deinit(); above there, which will wait until all tasks are finished. If your application hangs, double check that your std.Progress.start have a matching node.end().

Followup Tasks

• remove error.UnsupportedClock from some error sets
• #30150
• https://github.com/ziglang/zig/issues/24510

---

closes https://github.com/ziglang/zig/issues/25738
closes #30131
closes #30189
closes #30593

This branch deletes `std.fs.File` in favor of `std.Io.File` and `std.fs.Dir` in favor of `std.Io.Dir`, as well as moving almost all `std.fs` API into `std.Io.Dir`. The main purpose is to integrate file system I/O with the `std.Io` interface, which is a major part of #30150. I also took advantage of the breakage to rename a number of file system APIs for consistency. ## Upgrade Guide Although it's a lot of breaking changes, unlike ["writergate"](https://github.com/ziglang/zig/pull/24329), this changeset is expected to be generally easy for Zig programmers to manage, because it does not require much critical thinking. For example, typical upgrade path will look something like this: ```diff -file.close(); +file.close(io); ``` Although your upgrade diff might be large, it will be quite simple to understand what needs to be done. ### Added: * `std.Io.Dir.hardLink` * `std.Io.Dir.Reader` * `std.Io.Dir.setFilePermissions` * `std.Io.Dir.setFileOwner` * `std.Io.File.NLink` ### Removed with no replacement: * `std.fs.realpathZ` * `std.fs.realpathW` * `std.fs.realpathW2` * `std.fs.makeDirAbsoluteZ` * `std.fs.deleteDirAbsoluteZ` * `std.fs.openDirAbsoluteZ` * `std.fs.renameAbsoluteZ` * `std.fs.renameZ` * `std.fs.deleteTreeAbsolute` * `std.fs.symLinkAbsoluteW` * `std.fs.Dir.realpathZ` * `std.fs.Dir.realpathW` * `std.fs.Dir.realpathW2` * `std.fs.Dir.deleteFileZ` * `std.fs.Dir.deleteFileW` * `std.fs.Dir.deleteDirZ` * `std.fs.Dir.deleteDirW` * `std.fs.Dir.renameZ` * `std.fs.Dir.renameW` * `std.fs.Dir.symLinkWasi` * `std.fs.Dir.symLinkZ` * `std.fs.Dir.symLinkW` * `std.fs.Dir.readLinkWasi` * `std.fs.Dir.readLinkZ` * `std.fs.Dir.readLinkW` * `std.fs.Dir.adaptToNewApi` * `std.fs.Dir.adaptFromNewApi` * `std.fs.File.isCygwinPty` * `std.fs.File.adaptToNewApi` * `std.fs.File.adaptFromNewApi` ### Changed: Many functions now have a `std.Io` parameter. * `std.fs.copyFileAbsolute` -> `std.Io.Dir.copyFileAbsolute` * `std.fs.makeDirAbsolute` -> `std.Io.Dir.createDirAbsolute` * `std.fs.deleteDirAbsolute` -> `std.Io.Dir.deleteDirAbsolute` * `std.fs.openDirAbsolute` -> `std.Io.Dir.openDirAbsolute` * `std.fs.openFileAbsolute` -> `std.Io.Dir.openFileAbsolute` * `std.fs.accessAbsolute` -> `std.Io.Dir.accessAbsolute` * `std.fs.createFileAbsolute` -> `std.Io.Dir.createFileAbsolute` * `std.fs.deleteFileAbsolute` -> `std.Io.Dir.deleteFileAbsolute` * `std.fs.renameAbsolute` -> `std.Io.Dir.renameAbsolute` * `std.fs.readLinkAbsolute` -> `std.Io.Dir.readLinkAbsolute` * `std.fs.symLinkAbsolute` -> `std.Io.Dir.symLinkAbsolute` * `std.fs.has_executable_bit` -> `std.Io.File.Permissions.has_executable_bit` * `std.fs.realpath` -> `std.Io.Dir.realPathFileAbsolute` * `std.fs.rename` -> `std.Io.Dir.rename` * `std.fs.cwd` -> `std.Io.Dir.cwd` * `std.fs.defaultWasiCwd` -> `std.os.defaultWasiCwd` * `std.fs.realpathAlloc` -> `std.Io.Dir.realPathFileAbsoluteAlloc` * `std.fs.openSelfExe` -> `std.process.openExecutable` * `std.fs.selfExePathAlloc` -> `std.process.executablePathAlloc` * `std.fs.selfExePath` -> `std.process.executablePath` * `std.fs.selfExeDirPath` -> `std.process.executableDirPath` * `std.fs.selfExeDirPathAlloc` -> `std.process.executableDirPathAlloc` * `std.fs.Dir.setAsCwd` -> `std.process.setCurrentDir` * `std.fs.Dir.realpath` -> `std.Io.Dir.realPathFile` * `std.fs.Dir.realpathAlloc` -> `std.Io.Dir.realPathFileAlloc` * `std.fs.Dir` -> `std.Io.Dir` * `std.fs.File` -> `std.Io.File` * `std.fs.Dir.makeDir` -> `std.Io.Dir.createDir` * `std.fs.Dir.makePath` -> `std.Io.Dir.createDirPath` * `std.fs.Dir.makeOpenDir` -> `std.Io.Dir.createDirPathOpen` * `std.fs.Dir.rename`: now accepts two `Dir` parameters (plus `Io`) * `std.fs.Dir.atomicSymLink` -> `std.Io.Dir.symLinkAtomic` * `std.fs.Dir.chmod` -> `std.Io.Dir.setPermissions` * `std.fs.Dir.chown` -> `std.Io.Dir.setOwner` * `std.fs.File.Mode` -> `std.Io.File.Permissions` * `std.fs.File.PermissionsWindows` -> `std.Io.File.Permissions` * `std.fs.File.PermissionsUnix` -> `std.Io.File.Permissions` * `std.fs.File.default_mode` -> `std.Io.File.Permissions.default_file` * `std.fs.File.getOrEnableAnsiEscapeSupport` -> `std.Io.File.enableAnsiEscapeCodes` * `std.fs.File.setEndPos` -> `std.Io.File.setLength` * `std.fs.File.getEndPos` -> `std.Io.File.length` * `std.fs.File.seekTo`, `std.fs.File.seekBy`, `std.fs.File.seekFromEnd` -> `std.Io.File.Reader.seekTo`, `std.Io.File.Reader.seekBy`, `std.Io.File.Writer.seekTo` * `std.fs.File.getPos` -> `std.Io.File.Reader.logicalPos`, `std.Io.Writer.logicalPos` * `std.fs.File.mode()` -> `std.Io.File.stat().permissions.toMode` * `std.fs.File.chmod` -> `std.Io.File.setPermissions` * `std.fs.File.chown` -> `std.Io.File.setOwner` * `std.fs.File.updateTimes` -> `std.Io.File.setTimestamps`, `std.Io.File.setTimestampsNow` * `std.fs.File.read` -> `std.Io.File.readStreaming` * `std.fs.File.readv` -> `std.Io.File.readStreaming` * `std.fs.File.pread` -> `std.Io.File.readPositional` * `std.fs.File.preadv` -> `std.Io.File.readPositional` * `std.fs.File.preadAll` -> `std.Io.File.readPositionalAll` * `std.fs.File.write` -> `std.Io.File.writeStreaming` * `std.fs.File.writev` -> `std.Io.File.writeStreaming` * `std.fs.File.pwrite` -> `std.Io.File.writePositional` * `std.fs.File.pwritev` -> `std.Io.File.writePositional` * `std.fs.File.writeAll` -> `std.Io.File.writeStreamingAll` * `std.fs.File.pwriteAll` -> `std.Io.File.writePositionalAll` * `std.fs.File.copyRange`, `std.fs.File.copyRangeAll` -> `std.Io.File.writer` ### Deprecated: * `std.fs.path` -> `std.Io.Dir.path` * `std.fs.max_path_bytes` -> `std.Io.Dir.max_path_bytes` * `std.fs.max_name_bytes` -> `std.Io.Dir.max_name_bytes` ### `std.Progress` Note After updating your application that uses `std.Progress`: ```diff - const root_progress_node = std.Progress.start(.{ + const root_progress_node = std.Progress.start(io, .{ ``` Make sure you have `defer root_progress_node.end();` there. Before, if control flow got to the end of main(), start code would exit all threads, including the `std.Progress` thread. Now, it is not a thread but a task, and you likely have `defer threaded.deinit();` above there, which will wait until all tasks are finished. If your application hangs, double check that your `std.Progress.start` have a matching `node.end()`. ## Followup Tasks * remove error.UnsupportedClock from some error sets * #30150 * https://github.com/ziglang/zig/issues/24510 ---- closes https://github.com/ziglang/zig/issues/25738 closes #30131 closes #30189 closes #30593

🎉 27

andrewrk added the

release notes

breaking

lib/std

labels 2025-12-20 05:55:36 +01:00

andrewrk force-pushed std.Io-fs from e5c5b78399 to a8554912fb 2025-12-22 23:39:38 +01:00 Compare

andrewrk referenced this pull request 2025-12-23 01:12:18 +01:00

compiler/std-docs: update to use new Io, fixing #30131 #30573

andrewrk force-pushed std.Io-fs from 57390e70cb to e8153cfd0a 2025-12-23 06:04:49 +01:00 Compare

andrewrk commented 2025-12-23 21:20:54 +01:00

Author

Owner

Copy link

Lots of these:

test-cases
└─ run exe safety.slicing null C pointer - runtime len
   └─ compile exe safety.slicing null C pointer - runtime len Debug aarch64-linux failure
error: Compiler crash context:
       Generating function 'Io.Threaded.dirSetTimestamps'
       
       thread 1184089 panic: reached unreachable code
       /home/andy/src/zig/lib/std/debug.zig:419:14: 0x678b029 in assert (std.zig)
           if (!ok) unreachable; // assertion failure
                    ^
       /home/andy/src/zig/src/codegen/aarch64/Select.zig:12263:31: 0x936e3ba in param (main.zig)
                               assert(parts_len == part_sizes.len);
                                     ^
       /home/andy/src/zig/src/codegen/aarch64.zig:82:47: 0x9397f73 in generate (main.zig)
                   break :param_vi try param_it.param(&isel, param_ty);
                                                     ^
       /home/andy/src/zig/src/codegen.zig:163:45: 0x939bfce in generateFunction (main.zig)
                   const mir = try CodeGen.generate(lf, pt, src_loc, func_index, air, liveness);
                                                   ^
       /home/andy/src/zig/src/Zcu/PerThread.zig:4612:36: 0x8d0d177 in runCodegenInner (main.zig)
           return codegen.generateFunction(lf, pt, zcu.navSrcLoc(nav), func_index, air, &liveness) catch |err| switch (err) {
                                          ^
       /home/andy/src/zig/src/Zcu/PerThread.zig:4488:43: 0x85dc75f in runCodegen (main.zig)
           const codegen_result = runCodegenInner(pt, func_index, air);
                                                 ^
       /home/andy/src/zig/src/Zcu.zig:5002:29: 0x7f891f4 in workerCodegenOwnedAir (main.zig)
               return pt.runCodegen(func_index, &air);
                                   ^
       /home/andy/src/zig/lib/std/Io.zig:2086:13: 0x795c4ff in start (std.zig)
                   result_casted.* = @call(.auto, function, args_casted.*);
                   ^
       /home/andy/src/zig/lib/std/Io/Threaded.zig:1081:16: 0x686bf2e in start (std.zig)
               ac.func(ac.contextPointer(), ac.resultPointer());
                      ^
       /home/andy/src/zig/lib/std/Io/Threaded.zig:755:26: 0x68f6be7 in worker (std.zig)
                   closure.start(closure, t);
                                ^
       /home/andy/src/zig/lib/std/Thread.zig:558:13: 0x68b3700 in callFn__anon_37224 (std.zig)
                   @call(.auto, f, args);
                   ^
       /home/andy/src/zig/lib/std/Thread.zig:829:30: 0x686caa9 in entryFn (std.zig)
                       return callFn(f, args_ptr.*);
                                    ^
       ???:?:?: 0x7f38b52978ed in start_thread (/nix/store/g8zyryr9cr6540xsyg4avqkwgxpnwj2a-glibc-2.40-66/lib/libc.so.6)
       ???:?:?: 0x7f38b531b9bb in __clone3 (/nix/store/g8zyryr9cr6540xsyg4avqkwgxpnwj2a-glibc-2.40-66/lib/libc.so.6)
       Compiler crash context:
       Generating function 'Io.Threaded.fileSetTimestamps'
error: process terminated unexpectedly
failed command: /home/andy/src/zig/build-release/stage4/bin/zig build-exe -fno-llvm -fno-lld -ODebug -target aarch64-linux -mcpu baseline -Mroot=/home/andy/src/zig/.zig-cache/o/aed59870eb519527fd6ac5f6397f24aa/tmp.zig --cache-dir /home/andy/src/zig/.zig-cache --global-cache-dir /home/andy/.cache/zig --name "safety.slicing null C pointer - runtime len" --zig-lib-dir /home/andy/src/zig/lib/ --listen=-

@jacobly shall I disable the test coverage, or do you want to land a fix prior to merging?

Lots of these: ``` test-cases └─ run exe safety.slicing null C pointer - runtime len └─ compile exe safety.slicing null C pointer - runtime len Debug aarch64-linux failure error: Compiler crash context: Generating function 'Io.Threaded.dirSetTimestamps' thread 1184089 panic: reached unreachable code /home/andy/src/zig/lib/std/debug.zig:419:14: 0x678b029 in assert (std.zig) if (!ok) unreachable; // assertion failure ^ /home/andy/src/zig/src/codegen/aarch64/Select.zig:12263:31: 0x936e3ba in param (main.zig) assert(parts_len == part_sizes.len); ^ /home/andy/src/zig/src/codegen/aarch64.zig:82:47: 0x9397f73 in generate (main.zig) break :param_vi try param_it.param(&isel, param_ty); ^ /home/andy/src/zig/src/codegen.zig:163:45: 0x939bfce in generateFunction (main.zig) const mir = try CodeGen.generate(lf, pt, src_loc, func_index, air, liveness); ^ /home/andy/src/zig/src/Zcu/PerThread.zig:4612:36: 0x8d0d177 in runCodegenInner (main.zig) return codegen.generateFunction(lf, pt, zcu.navSrcLoc(nav), func_index, air, &liveness) catch |err| switch (err) { ^ /home/andy/src/zig/src/Zcu/PerThread.zig:4488:43: 0x85dc75f in runCodegen (main.zig) const codegen_result = runCodegenInner(pt, func_index, air); ^ /home/andy/src/zig/src/Zcu.zig:5002:29: 0x7f891f4 in workerCodegenOwnedAir (main.zig) return pt.runCodegen(func_index, &air); ^ /home/andy/src/zig/lib/std/Io.zig:2086:13: 0x795c4ff in start (std.zig) result_casted.* = @call(.auto, function, args_casted.*); ^ /home/andy/src/zig/lib/std/Io/Threaded.zig:1081:16: 0x686bf2e in start (std.zig) ac.func(ac.contextPointer(), ac.resultPointer()); ^ /home/andy/src/zig/lib/std/Io/Threaded.zig:755:26: 0x68f6be7 in worker (std.zig) closure.start(closure, t); ^ /home/andy/src/zig/lib/std/Thread.zig:558:13: 0x68b3700 in callFn__anon_37224 (std.zig) @call(.auto, f, args); ^ /home/andy/src/zig/lib/std/Thread.zig:829:30: 0x686caa9 in entryFn (std.zig) return callFn(f, args_ptr.*); ^ ???:?:?: 0x7f38b52978ed in start_thread (/nix/store/g8zyryr9cr6540xsyg4avqkwgxpnwj2a-glibc-2.40-66/lib/libc.so.6) ???:?:?: 0x7f38b531b9bb in __clone3 (/nix/store/g8zyryr9cr6540xsyg4avqkwgxpnwj2a-glibc-2.40-66/lib/libc.so.6) Compiler crash context: Generating function 'Io.Threaded.fileSetTimestamps' error: process terminated unexpectedly failed command: /home/andy/src/zig/build-release/stage4/bin/zig build-exe -fno-llvm -fno-lld -ODebug -target aarch64-linux -mcpu baseline -Mroot=/home/andy/src/zig/.zig-cache/o/aed59870eb519527fd6ac5f6397f24aa/tmp.zig --cache-dir /home/andy/src/zig/.zig-cache --global-cache-dir /home/andy/.cache/zig --name "safety.slicing null C pointer - runtime len" --zig-lib-dir /home/andy/src/zig/lib/ --listen=- ``` @jacobly shall I disable the test coverage, or do you want to land a fix prior to merging?

andrewrk force-pushed std.Io-fs from 75e3903a70 to c9a609a61a 2025-12-24 07:15:29 +01:00 Compare

andrewrk added 1 commit 2025-12-24 07:40:54 +01:00

fix the guess number game example 2708a3c1ac

andrewrk added 1 commit 2025-12-24 08:35:07 +01:00

std.Io.Threaded: implement process executable path on darwin a901e92413

andrewrk added 1 commit 2025-12-24 08:47:44 +01:00

std.Io.Threaded: prevent 0-byte file writes ... ace08ba642

these cause EINVAL on darwin and are generally a wasted syscall.

and remove a bogus error from File.Writer.Error.

andrewrk added 1 commit 2025-12-24 09:56:07 +01:00

std.Io.Threaded: wasi does not support processExecutablePath 6f4e93f0dd

andrewrk referenced this pull request 2025-12-24 20:51:06 +01:00

std.Io.Threaded should use futex on OpenBSD #30063

andrewrk commented 2025-12-24 22:05:32 +01:00

Author

Owner

Copy link

Another one:

       stack trace:
       /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/codegen/aarch64/Select.zig:12026:29: 0x89128f6 in finishReturn (zig)
                           else => unreachable,
                                   ^
       /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/codegen/aarch64/Select.zig:3649:34: 0x823db64 in body (zig)
                   try call.finishReturn(isel);
                                        ^
       /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/codegen/aarch64/Select.zig:4575:30: 0x824cbf9 in body (zig)
                       try isel.body(case.body);
                                    ^
       /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/codegen/aarch64/Select.zig:4529:26: 0x824bf4a in body (zig)
                   try isel.body(@ptrCast(isel.air.extra.items[extra.end + extra.data.then_body_len ..][0..extra.data.else_body_len]));
                                ^
       /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/codegen/aarch64/Select.zig:8006:18: 0x891419c in block (zig)
           try isel.body(air_body);
                        ^
       /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/codegen/aarch64/Select.zig:3520:27: 0x823c1cd in body (zig)
                   try isel.block(air.inst_index, ty_pl.ty.toType(), @ptrCast(
                                 ^
       /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/codegen/aarch64.zig:155:18: 0x821d2eb in generate (zig)
           try isel.body(air_main_body);
                        ^
       /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/codegen.zig:163:45: 0x7decf57 in generateFunction (zig)
                   const mir = try CodeGen.generate(lf, pt, src_loc, func_index, air, liveness);
                                                   ^
       /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/Zcu/PerThread.zig:4612:36: 0x7968d43 in runCodegenInner (zig)
           return codegen.generateFunction(lf, pt, zcu.navSrcLoc(nav), func_index, air, &liveness) catch |err| switch (err) {
                                          ^
       /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/Zcu/PerThread.zig:4488:43: 0x73f094b in runCodegen (zig)
           const codegen_result = runCodegenInner(pt, func_index, air);
                                                 ^
       /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/Zcu.zig:5002:29: 0x701b35e in workerCodegenOwnedAir (zig)
               return pt.runCodegen(func_index, &air);
                                   ^
       /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/lib/std/Io.zig:2087:13: 0x6b33c3d in start (zig)
                   result_casted.* = @call(.auto, function, args_casted.*);
                   ^
       /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/lib/std/Io/Threaded.zig:1086:16: 0x5f87a05 in start (zig)
               ac.func(ac.contextPointer(), ac.resultPointer());
                      ^
       /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/lib/std/Io/Threaded.zig:758:26: 0x5ff88b1 in worker (zig)
                   closure.start(closure, t);
                                ^
       /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/lib/std/Thread.zig:558:13: 0x5fc035d in callFn__anon_36861 (zig)
                   @call(.auto, f, args);
                   ^
       /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/lib/std/Thread.zig:829:30: 0x5f888ab in entryFn (zig)
                       return callFn(f, args_ptr.*);
                                    ^

error: process terminated unexpectedly
failed command: /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/build-debug-llvm/stage3-debug/bin/zig test -fno-llvm -fno-lld -fstrip -fbuiltin -OReleaseFast -target aarch64-linux-none -mcpu baseline -Mroot=/home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/lib/compiler_rt.zig --cache-dir /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/zig-local-cache --global-cache-dir /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/zig-global-cache --name test -L /home/ci/deps/zig+llvm+lld+clang-x86_64-linux-musl-0.16.0-dev.104+689461e31/lib -I /home/ci/deps/zig+llvm+lld+clang-x86_64-linux-musl-0.16.0-dev.104+689461e31/include --zig-lib-dir /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/lib --listen=-

I'm going to fully disable aarch64 backend tests for now.

Another one: ``` stack trace: /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/codegen/aarch64/Select.zig:12026:29: 0x89128f6 in finishReturn (zig) else => unreachable, ^ /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/codegen/aarch64/Select.zig:3649:34: 0x823db64 in body (zig) try call.finishReturn(isel); ^ /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/codegen/aarch64/Select.zig:4575:30: 0x824cbf9 in body (zig) try isel.body(case.body); ^ /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/codegen/aarch64/Select.zig:4529:26: 0x824bf4a in body (zig) try isel.body(@ptrCast(isel.air.extra.items[extra.end + extra.data.then_body_len ..][0..extra.data.else_body_len])); ^ /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/codegen/aarch64/Select.zig:8006:18: 0x891419c in block (zig) try isel.body(air_body); ^ /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/codegen/aarch64/Select.zig:3520:27: 0x823c1cd in body (zig) try isel.block(air.inst_index, ty_pl.ty.toType(), @ptrCast( ^ /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/codegen/aarch64.zig:155:18: 0x821d2eb in generate (zig) try isel.body(air_main_body); ^ /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/codegen.zig:163:45: 0x7decf57 in generateFunction (zig) const mir = try CodeGen.generate(lf, pt, src_loc, func_index, air, liveness); ^ /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/Zcu/PerThread.zig:4612:36: 0x7968d43 in runCodegenInner (zig) return codegen.generateFunction(lf, pt, zcu.navSrcLoc(nav), func_index, air, &liveness) catch |err| switch (err) { ^ /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/Zcu/PerThread.zig:4488:43: 0x73f094b in runCodegen (zig) const codegen_result = runCodegenInner(pt, func_index, air); ^ /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/src/Zcu.zig:5002:29: 0x701b35e in workerCodegenOwnedAir (zig) return pt.runCodegen(func_index, &air); ^ /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/lib/std/Io.zig:2087:13: 0x6b33c3d in start (zig) result_casted.* = @call(.auto, function, args_casted.*); ^ /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/lib/std/Io/Threaded.zig:1086:16: 0x5f87a05 in start (zig) ac.func(ac.contextPointer(), ac.resultPointer()); ^ /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/lib/std/Io/Threaded.zig:758:26: 0x5ff88b1 in worker (zig) closure.start(closure, t); ^ /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/lib/std/Thread.zig:558:13: 0x5fc035d in callFn__anon_36861 (zig) @call(.auto, f, args); ^ /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/lib/std/Thread.zig:829:30: 0x5f888ab in entryFn (zig) return callFn(f, args_ptr.*); ^ error: process terminated unexpectedly failed command: /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/build-debug-llvm/stage3-debug/bin/zig test -fno-llvm -fno-lld -fstrip -fbuiltin -OReleaseFast -target aarch64-linux-none -mcpu baseline -Mroot=/home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/lib/compiler_rt.zig --cache-dir /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/zig-local-cache --global-cache-dir /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/zig-global-cache --name test -L /home/ci/deps/zig+llvm+lld+clang-x86_64-linux-musl-0.16.0-dev.104+689461e31/lib -I /home/ci/deps/zig+llvm+lld+clang-x86_64-linux-musl-0.16.0-dev.104+689461e31/include --zig-lib-dir /home/ci/.cache/act/8818d6f864b3b4d3/hostexecutor/lib --listen=- ``` I'm going to fully disable aarch64 backend tests for now.

andrewrk added 2 commits 2025-12-25 02:04:25 +01:00

build.zig: adjust max_rss for unit tests ... 02e560d9ef

this isn't meant to be a precisely measured thing that is different per
operating system. it's meant to have some room for growth but not too
much.

std.Io.Threaded: dirRealPathFilePosix use libc realpath sometimes ... 315bc10a0c

When linking libc, and the directory is the cwd.

This avoids bugs on FreeBSD.

alexrp referenced this pull request 2025-12-26 18:08:55 +01:00

fix: remove assert for statx(2) #30593

linxy referenced this pull request 2025-12-26 18:17:20 +01:00

fix: remove assert for statx(2) #30593

andrewrk force-pushed std.Io-fs from 27510854ce to d8460910b4 2025-12-27 04:59:25 +01:00 Compare

andrewrk scheduled this pull request to auto merge when all checks succeed 2025-12-27 05:01:05 +01:00

andrewrk referenced this pull request 2025-12-27 05:17:57 +01:00

fix: remove assert for statx(2) #30593

mlugg force-pushed std.Io-fs from f2ab220bdc to 60a1ba0a8f 2025-12-27 11:25:44 +01:00 Compare

andrewrk merged commit e55e6b5528 into master 2025-12-27 14:10:53 +01:00

andrewrk referenced this pull request from a commit 2025-12-27 14:11:29 +01:00

Merge pull request 'std: migrate all `fs` APIs to `Io`' (#30232) from std.Io-fs into master

andrewrk deleted branch std.Io-fs 2025-12-27 14:11:30 +01:00

chrboesch referenced this pull request from ziglings/exercises 2025-12-27 14:38:27 +01:00

Integrate file system I/O with the std.Io interface #339

linxy referenced this pull request 2025-12-27 15:16:20 +01:00

fix: remove assert for statx(2) #30593

squeek502 referenced this pull request 2025-12-28 07:47:10 +01:00

Progress tree flickers on Windows Terminal #30611

squeek502 referenced this pull request 2025-12-28 11:01:42 +01:00

Dir.Iterator: Prioritize REPARSE_POINT over DIRECTORY when reporting kind on Windows #30188

squeek502 referenced this pull request 2025-12-28 11:02:13 +01:00

Encountered std.posix.UnexpectedError reading certain symlinks on Windows #30164

saurabh commented 2025-12-28 22:02:48 +01:00

Contributor

Copy link

std.fs.File.getEndPos -> std.Io.File.getLength

The getLength function doesn't exist in std.Io.File, however, I am able the length function for this functionality.

Is there a typo here or should I create a PR renaming length to getLength ?

> `std.fs.File.getEndPos -> std.Io.File.getLength` The `getLength` function doesn't exist in `std.Io.File`, however, I am able the `length` function for this functionality. Is there a typo here or should I create a PR renaming `length` to `getLength` ?

saurabh referenced this pull request from a commit 2025-12-28 22:57:58 +01:00

incorporate https://codeberg.org/ziglang/zig/pulls/30232; remove duplicate test

nyx-xyn referenced this pull request 2025-12-29 00:43:48 +01:00

std.Io.Dir: pass io to Walker.leave #30612

andrewrk commented 2026-01-02 04:45:52 +01:00

Author

Owner

Copy link

Thank you, it is a typo here

Thank you, it is a typo here

👍 1

sfiedler commented 2026-01-06 20:33:39 +01:00

Contributor

Copy link

Just to have it documented here (for release notes): This breaks stack walking on freestanding by making things like captureStackTrace implicitly depend on std.Options.debug_io.

There, we, on freestanding, need to set root.std_options_debug_io to some std.Io interface that:

• needs to work when we have our debug.SelfInfo.can_unwind == true (iirc) and our unwind_frame function actually uses any function from the std.Io interface
• does not need to work when we either use stack unwinding (called the "unsafe" option) or don't use the std.Io interface while unwinding (if it stays so that captureStackTrace does nothing with the io parameter and only gives it to unwindFrame).

Option 2 ("does not need to work") could be #30691.

Just to have it documented here (for release notes): This breaks stack walking on freestanding by making things like `captureStackTrace` implicitly depend on `std.Options.debug_io`. There, we, on freestanding, need to set `root.std_options_debug_io` to some `std.Io` interface that: * needs to work when we have our `debug.SelfInfo.can_unwind == true` (iirc) and our `unwind_frame` function actually uses any function from the std.Io interface * does not need to work when we either use stack unwinding (called the "unsafe" option) or don't use the std.Io interface while unwinding (if it stays so that captureStackTrace does nothing with the `io` parameter and only gives it to `unwindFrame`). Option 2 ("does not need to work") could be #30691.

andrewrk commented 2026-01-06 21:02:11 +01:00

Author

Owner

Copy link

This is a closed issue, could you make an open issue to track that problem, please?

This is a closed issue, could you make an open issue to track that problem, please?

👍 1

squeek502 referenced this pull request 2026-03-10 08:16:10 +01:00

Add a few fs test cases from otherwise obsoleted PRs #31437

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

abi/f32

  

abi/ilp32

  

abi/n32

  

abi/sf

  

abi/x32

  

accepted

This proposal is planned.

  

arch/1750a

  

arch/21k

  

arch/6502

  

arch/a29k

  

arch/aarch64

  

arch/alpha

  

arch/amdgcn

  

arch/arc

  

arch/arc32

  

arch/arc64

  

arch/arm

  

arch/avr

  

arch/avr32

  

arch/bfin

  

arch/bpf

  

arch/clipper

  

arch/colossus

  

arch/cr16

  

arch/cris

  

arch/csky

  

arch/dlx

  

arch/dsp16xx

  

arch/elxsi

  

arch/epiphany

  

arch/fr30

  

arch/frv

  

arch/h8300

  

arch/h8500

  

arch/hexagon

  

arch/hppa

  

arch/hppa64

  

arch/i370

  

arch/i860

  

arch/i960

  

arch/ia64

  

arch/ip2k

  

arch/kalimba

  

arch/kvx

  

arch/lanai

  

arch/lm32

  

arch/loongarch32

  

arch/loongarch64

  

arch/m32r

  

arch/m68k

  

arch/m88k

  

arch/maxq

  

arch/mcore

  

arch/metag

  

arch/microblaze

  

arch/mips

  

arch/mips64

  

arch/mmix

  

arch/mn10200

  

arch/mn10300

  

arch/moxie

  

arch/mrisc32

  

arch/msp430

  

arch/nds32

  

arch/nios2

  

arch/ns32k

  

arch/nvptx

  

arch/or1k

  

arch/pdp10

  

arch/pdp11

  

arch/pj

  

arch/powerpc

  

arch/powerpc64

  

arch/propeller

  

arch/riscv32

  

arch/riscv64

  

arch/rl78

  

arch/rx

  

arch/s390

  

arch/s390x

  

arch/sh

  

arch/sh64

  

arch/sparc

  

arch/sparc64

  

arch/spirv

  

arch/spu

  

arch/st200

  

arch/starcore

  

arch/tilegx

  

arch/tilepro

  

arch/tricore

  

arch/ts

  

arch/ubicom8

  

arch/v850

  

arch/vax

  

arch/vc4

  

arch/ve

  

arch/wasm

  

arch/we32k

  

arch/x86

  

arch/x86_64

  

arch/xcore

  

arch/xgate

  

arch/xstormy16

  

arch/xtensa

  

autodoc

The web application for interactive documentation and generation of its assets.

  

backend/c

The C backend outputs C source code.

  

backend/llvm

The LLVM backend outputs an LLVM bitcode module.

  

backend/self-hosted

The self-hosted backends produce machine code directly.

  

binutils

Zig's included binary utilities: zig ar, zig dlltool, zig lib, zig ranlib, zig objcopy, and zig rc.

  

breaking

Implementing this issue could cause existing code to no longer compile or have different behavior.

  

build system

The Zig build system - zig build, std.Build, the build runner, and package management.

  

debug info

An issue related to debug information (e.g. DWARF) produced by the Zig compiler.

  

docs

An issue with documentation, e.g. the language reference or standard library doc comments.

  

error message

This issue points out an error message that is unhelpful and should be improved.

  

frontend

Tokenization, parsing, AstGen, ZonGen, Sema, Legalize, and Liveness.

  

fuzzing

An issue related to Zig's integrated fuzz testing.

  

incremental

Reuse of internal compiler state for faster compilation.

  

lib/c

This issue relates to Zig's libc implementation and/or vendored libcs.

  

lib/compiler-rt

This issue relates to Zig's compiler-rt library.

  

lib/cxx

This issue relates to Zig's vendored libc++ and/or libc++abi.

  

lib/std

This issue relates to Zig's standard library.

  

lib/tsan

This issue relates to Zig's vendored libtsan.

  

lib/ubsan-rt

This issue relates to Zig's ubsan-rt library.

  

lib/unwind

This issue relates to Zig's vendored libunwind.

  

linking

Zig's integrated object file and incremental linker.

  

miscompilation

The compiler reports success but produces semantically incorrect code.

  

os/aix

  

os/android

  

os/bridgeos

  

os/contiki

  

os/dragonfly

  

os/driverkit

  

os/emscripten

  

os/freebsd

  

os/fuchsia

  

os/haiku

  

os/hermit

  

os/hurd

  

os/illumos

  

os/ios

  

os/kfreebsd

  

os/linux

  

os/maccatalyst

  

os/macos

  

os/managarm

  

os/netbsd

  

os/ohos

  

os/openbsd

  

os/plan9

  

os/redox

  

os/rtems

  

os/serenity

  

os/solaris

  

os/tvos

  

os/uefi

  

os/visionos

  

os/wali

  

os/wasi

  

os/watchos

  

os/windows

  

os/zos

  

proposal

This issue suggests modifications. If it also has the "accepted" label then it is planned.

  

release notes

This issue or pull request should be mentioned in the release notes.

  

testing

This issue is related to testing the compiler, standard library, or other parts of Zig.

  

tier system

This issue tracks the support tier for a target.

  

zig cc

Zig as a drop-in C-family compiler.

  

zig fmt

The Zig source code formatter.

  

bounty

https://ziglang.org/news/announcing-donor-bounties

  

bug

Observed behavior contradicts documented or intended behavior.

  

contributor-friendly

This issue is limited in scope and/or knowledge of project internals.

  

downstream

An issue with a third-party project that uses this project.

  

enhancement

Solving this issue will likely involve adding new logic or components to the codebase.

  

infra

An issue related to project infrastructure, e.g. continuous integration.

  

optimization

A task to improve performance and/or resource usage.

  

question

No questions on the issue tracker; use a community space instead.

  

regression

Something that used to work in a previous version stopped working

  

upstream

An issue with a third-party project that this project uses.

No labels

abi/f32

abi/ilp32

abi/n32

abi/sf

abi/x32

accepted

arch/1750a

arch/21k

arch/6502

arch/a29k

arch/aarch64

arch/alpha

arch/amdgcn

arch/arc

arch/arc32

arch/arc64

arch/arm

arch/avr

arch/avr32

arch/bfin

arch/bpf

arch/clipper

arch/colossus

arch/cr16

arch/cris

arch/csky

arch/dlx

arch/dsp16xx

arch/elxsi

arch/epiphany

arch/fr30

arch/frv

arch/h8300

arch/h8500

arch/hexagon

arch/hppa

arch/hppa64

arch/i370

arch/i860

arch/i960

arch/ia64

arch/ip2k

arch/kalimba

arch/kvx

arch/lanai

arch/lm32

arch/loongarch32

arch/loongarch64

arch/m32r

arch/m68k

arch/m88k

arch/maxq

arch/mcore

arch/metag

arch/microblaze

arch/mips

arch/mips64

arch/mmix

arch/mn10200

arch/mn10300

arch/moxie

arch/mrisc32

arch/msp430

arch/nds32

arch/nios2

arch/ns32k

arch/nvptx

arch/or1k

arch/pdp10

arch/pdp11

arch/pj

arch/powerpc

arch/powerpc64

arch/propeller

arch/riscv32

arch/riscv64

arch/rl78

arch/rx

arch/s390

arch/s390x

arch/sh

arch/sh64

arch/sparc

arch/sparc64

arch/spirv

arch/spu

arch/st200

arch/starcore

arch/tilegx

arch/tilepro

arch/tricore

arch/ts

arch/ubicom8

arch/v850

arch/vax

arch/vc4

arch/ve

arch/wasm

arch/we32k

arch/x86

arch/x86_64

arch/xcore

arch/xgate

arch/xstormy16

arch/xtensa

autodoc

backend/c

backend/llvm

backend/self-hosted

binutils

breaking

build system

debug info

docs

error message

frontend

fuzzing

incremental

lib/c

lib/compiler-rt

lib/cxx

lib/std

lib/tsan

lib/ubsan-rt

lib/unwind

linking

miscompilation

os/aix

os/android

os/bridgeos

os/contiki

os/dragonfly

os/driverkit

os/emscripten

os/freebsd

os/fuchsia

os/haiku

os/hermit

os/hurd

os/illumos

os/ios

os/kfreebsd

os/linux

os/maccatalyst

os/macos

os/managarm

os/netbsd

os/ohos

os/openbsd

os/plan9

os/redox

os/rtems

os/serenity

os/solaris

os/tvos

os/uefi

os/visionos

os/wali

os/wasi

os/watchos

os/windows

os/zos

proposal

release notes

testing

tier system

zig cc

zig fmt

bounty

bug

contributor-friendly

downstream

enhancement

infra

optimization

question

regression

upstream

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

4 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ziglang/zig!30232

No description provided.