Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Improve xmpp filter branch #966
Conversation
| @@ -11,4 +11,7 @@ commit list, instead of tweeting all commits individually with their message and | |||
| Check "Short format" to omit the repository and commiter's names from the tweet to get more | |||
| space for the commit message. | |||
|
|
|||
| If you would like to restrict to a branch then add the name, otherwise blank means 'all'. | |||
kdaigle
Nov 14, 2014
Member
Can you clarify this? Maybe: If you would like to only receive messages for a specific branch, add the name (or partial name) to the "Filter branch" option. Otherwise, leave the field blank to receive messages for all branches.
Can you clarify this? Maybe: If you would like to only receive messages for a specific branch, add the name (or partial name) to the "Filter branch" option. Otherwise, leave the field blank to receive messages for all branches.
|
updated :) |
| @@ -33,6 +33,7 @@ def receive_event | |||
| return false if event.to_s =~ /pull_/ && !data['notify_pull'] | |||
|
|
|||
| build_message(event, payload) | |||
| return true | |||
kdaigle
Nov 24, 2014
Member
Not sure this return true is needed here. This just accidental or was it not working without it?
Not sure this return true is needed here. This just accidental or was it not working without it?
lloydwatkin
Nov 24, 2014
Author
Contributor
Added so I could use the result in unit tests, i.e. everything ok I get 'true' in return.
Added so I could use the result in unit tests, i.e. everything ok I get 'true' in return.
…ve-xmpp-filter-branch Conflicts: docs/twitter
…ithub-services into improve-xmpp-filter-branch Conflicts: docs/twitter
| @@ -21,6 +21,9 @@ This service will connect to an XMPP MUC room with the provided details and then | |||
| 5. **Notify issues** - Get notifications on issues | |||
| 6. **Notify pull requests** - Get notifications of pull requests | |||
|
|
|||
| If you would like to only receive messages for a specific branch, add the name (or partial name) to | |||
| -the "Restrict to Branch" option. Otherwise, leave the field blank to receive messages for all branches. | |||
kdaigle
Dec 11, 2014
Member
Is there a reason for this dash here? Sorry to be pedantic but I found it confusing.
Is there a reason for this dash here? Sorry to be pedantic but I found it confusing.
|
@kdaigle no reason, removed. Pedantry isn't a problem :) |
|
|
|
\o/ Thanks
|
Allow partial matches on branch name