Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add the ability to filter twitter updates by branch #958
Conversation
|
+1 <3 |
| @@ -11,4 +11,6 @@ commit list, instead of tweeting all commits individually with their message and | |||
| Check "Short format" to omit the repository and commiter's names from the tweet to get more | |||
| space for the commit message. | |||
|
|
|||
| If you would like to restrict to a branch then add the name, otherwise blank means 'all'. | |||
domenic
Oct 27, 2014
Add the name where?
Add the name where?
|
@domenic updated, thanks. |
| filter_branch = data['filter_branch'].to_s | ||
|
|
||
| # If filtering by branch then don't make a post | ||
| if (filter_branch.length > 0) && (filter_branch.index(commit_branch) == nil) |
kdaigle
Nov 6, 2014
Member
Could you please add a test for this? Thanks!
Could you please add a test for this? Thanks!
|
Two tests added |
| @@ -11,4 +11,6 @@ commit list, instead of tweeting all commits individually with their message and | |||
| Check "Short format" to omit the repository and commiter's names from the tweet to get more | |||
| space for the commit message. | |||
|
|
|||
| If you would like to restrict to a branch then add the name to the 'filter branch' field, otherwise blank means 'all'. | |||
|
Updated :) |
Add the ability to filter twitter updates by branch
|
Thanks! This will be deployed in the next few days. |
|
I tried configuring this, but I don't see the filter branch option referred to in
|
|
@lloydwatkin @kdaigle anything I'm missing? Very confused as to what is going on here ... I was excited about using this feature. |
|
@domenic I think the UI hasn't been updated to match the new functionality. Nothing I can do I'm afraid. |
|
Maybe @technoweenie has time to look at this? |
|
Oh, interesting, I was wondering how the UI worked. I was hoping it was auto-generated from the field definitions, since I didn't see any code for it in this repo... sounds like maybe it's just hosted in some private repo somewhere. Eek. |
|
@lloydwatkin ah, it looks like you missed defining a |
|
@kdaigle oh, I do apologise! Will get a PR in immediately. |
|
See #996 |
/cc @domenic
https://twitter.com/domenic/status/526778249657864192