close

Make WordPress Themes

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#12419 closed theme (not-approved)

THEME: Jaguza - 1.0.1

Reported by: kakomap's profile kakomap Owned by: chickadeedesignery's profile chickadeedesignery
Priority: previously reviewed Keywords: theme-jaguza child-theme parent-twentytwelve
Cc: kakomap@…

Description

Jaguza - 1.0.1

Jaguza is a fully responsive, translation-ready theme built to make your blog very fast and look amazing. It is a child theme of the awesome TwentyTwelve theme developed by the WordPress Team. Features include unlimited theme color options with over 10 pre-built, heavily-customizable homepage, amazing easily-customizable slider(that can be disabled), a stylish social bar, in-built theme help, front page template with its own widgets and an optional no-sidebar page template. All these and many more are easy to change from a classy, super powerful, easy-to-use Admin panel. Jaguza was built for speed, beauty and ease-of-use

Theme URL - http://themes.blueboltlimited.com/jaguza
Author URL - http://kakoma.ug/

SVN - http://themes.svn.wordpress.org/jaguza/1.0.1
ZIP - http://wordpress.org/extend/themes/download/jaguza.1.0.1.zip?nostats=1
Parent Theme: http://wordpress.org/extend/themes/twentytwelve

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/jaguza/1.0.0&new_path=/jaguza/1.0.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-jaguza&order=id

https://themes.svn.wordpress.org/jaguza/1.0.1/screenshot.png

Attachments (1)

jaguza_third_level_links.png (270.9 KB) - added by kakomap 13 years ago.
Jaguza Third level navigation

Download all attachments as: .zip

Change History (6)

#1 Image @chipbennett
13 years ago

  • Keywords changed from theme-jaguza, child-theme, parent-twentytwelve to theme-jaguza child-theme, parent-twentytwelve
  • Owner set to chickadeedesignery
  • Status changed from new to reviewing

#2 Image @Otto42
13 years ago

  • Keywords changed from theme-jaguza child-theme, parent-twentytwelve to theme-jaguza child-theme parent-twentytwelve
  • Resolution set to not-approved
  • Status changed from reviewing to closed

I wish to make this perfectly clear:

"100% safe - ignore theme check nag"

There is no "theme check nag". Use of base64 encoding is not allowed for themes in the repository. Period.

If theme-check is failing the theme, then it has failed. "Warnings" are a failure condition.

The only reason this upload succeeded is because the theme-check system is bypassed for child themes. I suggest that you re-read the review guidelines, run theme check again, and this time, do not ignore the warnings and errors that it gives you.

#3 Image @chickadeedesignery
13 years ago

Hello! This was my first theme to review so once I asked the base64 question to Otto, he kindly stepped in to tell you what to do since it's a serious security error. But, while reviewing your theme, I also stumbled across a few more errors that you should also fix for your next submission.

Custom Header
remove_custom_image_header is deprecated since version 3.4. Use remove_theme_support( 'custom-header' ) instead. This error comes up if you turn on the wp_debug in the config file.

Navigation
The current navigation cuts off third level navigation links.

Header.php
Need to call out a character set. All non breaking spaces are showing up as the glyph a-circumflex.

You are also getting a few recommendations from Theme Check. I'm sure you've seen them if you put the note in about the base64 code but figured I might as well mention it.

Also, on a random note, I found it difficult to navigate through your theme and understand what everything was being used for. I think it might be helpful if you added a little more documentation, especially for the framework and blueprint since most people might not know what you are using that for since you don't explain.

Here are a few helpful links to help you sort out errors so your theme will be approved in the next round. Thanks again for applying!

Links
http://codex.wordpress.org/Theme_Review
http://wordpress.org/plugins/developer/
http://codex.wordpress.org/Theme_Unit_Test

#4 Image @chickadeedesignery
13 years ago

Oh, I also wanted to note that I didn't dive in too deep to the theme since I found additional errors to the base64 error. I would recommend following the checklist in the below link to hunt out any errors before you submit again.

This link is also helpful:
http://www.chipbennett.net/2011/04/20/a-guide-to-reviewing-themes-for-the-wordpress-theme-repository/

Image @kakomap
13 years ago

Jaguza Third level navigation

#5 Image @kakomap
13 years ago

Hi chickadeedesignery,
Thanks for joining the review team. God knows we need more people like you! And thanks for taking time off to review my theme. Great stuff. Now on to your comments:

  • remove_custom_image_header: I'll remove this...but note that this is a recommended change. It is not grounds to reject a theme. I left it in for now to support 3.4
  • Navigation: Kindly look at the attachment. Please clarify
  • Header.php is from the Twenty Twelve theme; that top bit is unchanged. Kindly look at Twenty Twelve...I'm sure the WordPress team that developed it took character sets into consideration
  • Base64 encoding has been removed. Please refer to my email...and to this http://themes.trac.wordpress.org/ticket/12964
  • Kindly look through the very detailed 'READ ME' file; you'll note that it contains a lot of useful information. Also, it may be helpful to get acquainted with the way the Twenty Twelve theme works and how it is set up
  • Lastly, there are no errors. Go through the checks

Kindly look through and revert. Thanks again.

Last edited 13 years ago by kakomap (previous) (diff)
Note: See TracTickets for help on using tickets.