close
Skip to content

Fixed parsing of json maps #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 8 commits into from
Mar 12, 2026
Merged

Fixed parsing of json maps #1

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cc800a7
Fixed parsing of json maps
robfelty Jul 11, 2024
70c7466
Fix indentation
swissspidy Nov 2, 2025
6ce3c8d
Fix indentation
swissspidy Nov 2, 2025
d79b455
Remove space
swissspidy Nov 2, 2025
4750172
Verify json decoding worked
swissspidy Nov 2, 2025
4ed1387
Merge branch 'master' into master
swissspidy Jan 20, 2026
a9250ad
Update src/Spyc.php
swissspidy Mar 12, 2026
1616ef6
Merge branch 'master' into master
swissspidy Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Verify json decoding worked 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
  • Loading branch information
@swissspidy
swissspidy and Copilot authored Nov 2, 2025
commit 47501728bc43049fb883f0ffcc24fe9fb16ab687
7 changes: 6 additions & 1 deletion src/Spyc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1065,7 +1065,12 @@ private function returnKeyValuePair ($line) {
$this->checkKeysInValue($value);
// Other methods currently don't parse valid json maps or arrays of maps correctly
if ( str_starts_with( $value, '[{' ) || str_starts_with( $value, '{"' ) ) {
$value = json_decode( preg_replace( '/^.*?:\s*/', '', $line ), true );
$decoded = json_decode( preg_replace( '/^.*?:\s*/', '', $line ), true );
if ($decoded !== null || (json_last_error() === JSON_ERROR_NONE && $decoded === null)) {
// Accept null as valid JSON value, but only if no error occurred
$value = $decoded;
}
// Otherwise, leave $value as-is (fallback to original string)
}
}
// Set the type of the value. Int, string, etc
Expand Down