close
Skip to content

bpo-36917: Add default implementation of ast.NodeVisitor.visit_Constant().#15490

Merged
serhiy-storchaka merged 2 commits intopython:masterfrom
serhiy-storchaka:visit-constant
Aug 26, 2019
Merged

bpo-36917: Add default implementation of ast.NodeVisitor.visit_Constant().#15490
serhiy-storchaka merged 2 commits intopython:masterfrom
serhiy-storchaka:visit-constant

Conversation

@serhiy-storchaka
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka commented Aug 25, 2019 •
edited by bedevere-bot
Loading

It emits a deprecation message and calls corresponding method
visit_Num(), visit_Str(), etc.

https://bugs.python.org/issue36917

@serhiy-storchaka
bpo-36917: Add default implementation of ast.NodeVisitor.visit_Consta…
62f8127 
…nt().

It emits a deprecation message and calls corresponding method
visit_Num(), visit_Str(), etc.
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.8 labels Aug 25, 2019
tirkarthi
tirkarthi reviewed Aug 25, 2019
View reviewed changes
@serhiy-storchaka @tirkarthi
Update Doc/whatsnew/3.8.rst
54de4cf 
Co-Authored-By: Xtreak <tir.karthi@gmail.com>
asottile
asottile approved these changes Aug 25, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

(not sure I agree with deprecating these in the same release, but at least this fixes the code it broke)

@serhiy-storchaka
Copy link
Copy Markdown
Member Author

serhiy-storchaka commented Aug 26, 2019

There are no much problems with the deprecation in the same release because visit_Constant is just ignored in older releases. It does not add any runtime cost, as well as old handlers like visit_Str will not add runtime cost in newer releases if you implemented visit_Constant.

@serhiy-storchaka serhiy-storchaka merged commit c3ea41e into python:master Aug 26, 2019
@serhiy-storchaka serhiy-storchaka deleted the visit-constant branch August 26, 2019 07:13
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 26, 2019

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 26, 2019
@serhiy-storchaka @miss-islington
bpo-36917: Add default implementation of ast.NodeVisitor.visit_Consta…
3d02195 
…nt(). (pythonGH-15490)

It emits a deprecation warning and calls corresponding method
visit_Num(), visit_Str(), etc.
(cherry picked from commit c3ea41e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Aug 26, 2019

GH-15509 is a backport of this pull request to the 3.8 branch.

serhiy-storchaka pushed a commit that referenced this pull request Aug 26, 2019
@miss-islington @serhiy-storchaka
[3.8] bpo-36917: Add default implementation of ast.NodeVisitor.visit_…
522a394 
…Constant(). (GH-15490) (GH-15509)

It emits a deprecation warning and calls corresponding method
visit_Num(), visit_Str(), etc.
(cherry picked from commit c3ea41e)
asottile
asottile reviewed Aug 26, 2019
View reviewed changes
Lib/ast.py
else:
import warnings
warnings.warn(f"{method} is deprecated; add visit_Constant",
DeprecationWarning, 2)
Copy link
Copy Markdown
Contributor

@asottile asottile Aug 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be PendingDeprecationWarning

Copy link
Copy Markdown
Member Author

@serhiy-storchaka serhiy-storchaka Aug 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a PendingDeprecationWarning in 3.8 and a DeprecationWarning in 3.9.

Copy link
Copy Markdown
Contributor

@asottile asottile Aug 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, this is to 3.9! Silly me

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@serhiy-storchaka @lisroach
bpo-36917: Add default implementation of ast.NodeVisitor.visit_Consta…
64eead5 
…nt(). (pythonGH-15490)

It emits a deprecation warning and calls corresponding method
visit_Num(), visit_Str(), etc.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@serhiy-storchaka @DinoV
bpo-36917: Add default implementation of ast.NodeVisitor.visit_Consta…
dfe2ace 
…nt(). (pythonGH-15490)

It emits a deprecation warning and calls corresponding method
visit_Num(), visit_Str(), etc.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@serhiy-storchaka @websurfer5
bpo-36917: Add default implementation of ast.NodeVisitor.visit_Consta…
81de324 
…nt(). (pythonGH-15490)

It emits a deprecation warning and calls corresponding method
visit_Num(), visit_Str(), etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi left review comments

+1 more reviewer

@asottile asottile asottile approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@serhiy-storchaka @miss-islington @bedevere-bot @asottile @tirkarthi @the-knights-who-say-ni