Wrap strings passed to libzip with zip_source_function_create()#21659
Open
tstarling wants to merge 1 commit intophp:masterfrom
Open
Wrap strings passed to libzip with zip_source_function_create()#21659tstarling wants to merge 1 commit intophp:masterfrom
tstarling wants to merge 1 commit intophp:masterfrom
Conversation
Wrap strings passed to libzip with zip_source_function_create() instead of using zip_source_buffer_create(). This allows us to make the string writable, and simplifies memory management.
8527d42 to
bb06b21
Compare
Member
|
Everything looked correct on an implementation level yesterday - I'll come back to this with fresh eyes in a few days and confirm that nothing looks off, and then merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap strings passed to libzip with zip_source_function_create() instead of using zip_source_buffer_create(). This allows us to make the string writable, and simplifies memory management.
Split from #21497 as requested by @DanielEScherzer