Fix _normalize_ip_key to properly normalize IP addresses#34
Merged
jonathan-kosgei merged 2 commits intomasterfrom Feb 25, 2026
Merged
Fix _normalize_ip_key to properly normalize IP addresses#34jonathan-kosgei merged 2 commits intomasterfrom
jonathan-kosgei merged 2 commits intomasterfrom
Conversation
Use ipaddress module instead of socket.inet_pton so that network host bits are zeroed (e.g. 192.168.1.100/24 → 192.168.1.0/24) and IPv6 addresses are compressed (e.g. 2001:0db8:0000:… → 2001:db8::1). https://claude.ai/code/session_01M3wRX9tnmc4qorVWRjmqTZ
Replace ipaddress module with socket.inet_pton/inet_ntop and manual bit masking. Avoids the overhead of constructing full Python ipaddress objects while still normalizing host bits and compressing IPv6. https://claude.ai/code/session_01M3wRX9tnmc4qorVWRjmqTZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use ipaddress module instead of socket.inet_pton so that network host bits are zeroed (e.g. 192.168.1.100/24 → 192.168.1.0/24) and IPv6 addresses are compressed (e.g. 2001:0db8:0000:… → 2001:db8::1).
https://claude.ai/code/session_01M3wRX9tnmc4qorVWRjmqTZ