Tags: dotnet/runtime
Tags
[release/11.0-preview2] Revert "Increase number of assertions (Global… …AP) + VN cache (#124132)" (#124955) Backport of #124928 to release/11.0-preview2 /cc @akoeplinger @AndyAyersMS ## Customer Impact - [ ] Customer reported - [x] Found internally This was causing excessive memory allocation during jitting (see dotnet/dotnet#4933). ## Regression - [X] Yes - [ ] No Caused by: 92741be ## Testing Manual testing. ## Risk Low. Reverts an earlier change. [High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.] **IMPORTANT**: If this backport is for a servicing release, please verify that: - For .NET 8 and .NET 9: The PR target branch is `release/X.0-staging`, not `release/X.0`. - For .NET 10+: The PR target branch is `release/X.0` (no `-staging` suffix). ## Package authoring no longer needed in .NET 9 **IMPORTANT**: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version. Keep in mind that we still need package authoring in .NET 8 and older versions. Co-authored-by: Andy Ayers <andya@microsoft.com>
[release/11.0-preview2] Revert "Increase number of assertions (Global… …AP) + VN cache (#124132)" (#124955) Backport of #124928 to release/11.0-preview2 /cc @akoeplinger @AndyAyersMS ## Customer Impact - [ ] Customer reported - [x] Found internally This was causing excessive memory allocation during jitting (see dotnet/dotnet#4933). ## Regression - [X] Yes - [ ] No Caused by: 92741be ## Testing Manual testing. ## Risk Low. Reverts an earlier change. [High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.] **IMPORTANT**: If this backport is for a servicing release, please verify that: - For .NET 8 and .NET 9: The PR target branch is `release/X.0-staging`, not `release/X.0`. - For .NET 10+: The PR target branch is `release/X.0` (no `-staging` suffix). ## Package authoring no longer needed in .NET 9 **IMPORTANT**: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version. Keep in mind that we still need package authoring in .NET 8 and older versions. Co-authored-by: Andy Ayers <andya@microsoft.com>
[release/11.0-preview2] Revert "Increase number of assertions (Global… …AP) + VN cache (#124132)" (#124955) Backport of #124928 to release/11.0-preview2 /cc @akoeplinger @AndyAyersMS ## Customer Impact - [ ] Customer reported - [x] Found internally This was causing excessive memory allocation during jitting (see dotnet/dotnet#4933). ## Regression - [X] Yes - [ ] No Caused by: 92741be ## Testing Manual testing. ## Risk Low. Reverts an earlier change. [High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.] **IMPORTANT**: If this backport is for a servicing release, please verify that: - For .NET 8 and .NET 9: The PR target branch is `release/X.0-staging`, not `release/X.0`. - For .NET 10+: The PR target branch is `release/X.0` (no `-staging` suffix). ## Package authoring no longer needed in .NET 9 **IMPORTANT**: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version. Keep in mind that we still need package authoring in .NET 8 and older versions. Co-authored-by: Andy Ayers <andya@microsoft.com>
[release/11.0-preview2] Revert "Increase number of assertions (Global… …AP) + VN cache (#124132)" (#124955) Backport of #124928 to release/11.0-preview2 /cc @akoeplinger @AndyAyersMS ## Customer Impact - [ ] Customer reported - [x] Found internally This was causing excessive memory allocation during jitting (see dotnet/dotnet#4933). ## Regression - [X] Yes - [ ] No Caused by: 92741be ## Testing Manual testing. ## Risk Low. Reverts an earlier change. [High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.] **IMPORTANT**: If this backport is for a servicing release, please verify that: - For .NET 8 and .NET 9: The PR target branch is `release/X.0-staging`, not `release/X.0`. - For .NET 10+: The PR target branch is `release/X.0` (no `-staging` suffix). ## Package authoring no longer needed in .NET 9 **IMPORTANT**: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version. Keep in mind that we still need package authoring in .NET 8 and older versions. Co-authored-by: Andy Ayers <andya@microsoft.com>
#124513 - Guard Base64Url.DecodeFromChars against non-ASCII input (#1… …24540) Base64Url.DecodeFromChars in Microsoft.Bcl.Memory has an out-of-bounds read bug: DecodeFrom uses Unsafe.Add with raw char values as indices into a 256-element DecodingMap without checking the DecodeRemaining return value first. Non-ASCII chars (value > ~2048) cause an AccessViolationException on .NET 8. Workaround: Add System.Text.Ascii.IsValid check before decoding to reject non-ASCII input early. Base64/Base64Url only uses ASCII characters, so any non-ASCII input is inherently invalid. Fixes #124513 --------- Co-authored-by: t.csala <t.csala@criteo.com>
[release/10.0] fix Vector2/3 EqualsAny (#124223) Backport of #123594 to release/10.0 /cc @tannergooding @kasperk81 ## Customer Impact - [x] Customer reported - [ ] Found internally Reported in #123586, developers using some of the new APIs exposed on Vector2 and Vector3 could get non-deterministic results in some scenarios. ## Regression - [ ] Yes - [x] No These are new APIs. ## Testing Explicit tests covering the scenarios were added in addition to manual verification of the codegen. ## Risk Low. These are net new APIs which could accidentally include invalid elements in the accelerated comparison. The fix was to ensure they used the existing centralized helpers that were exposed to help ensure such code was being consistently handled and avoid such problems. The APIs had simply not gotten checked in using them as intended. --------- Co-authored-by: kasperk81 <83082615+kasperk81@users.noreply.github.com>
[release/10.0] fix Vector2/3 EqualsAny (#124223) Backport of #123594 to release/10.0 /cc @tannergooding @kasperk81 ## Customer Impact - [x] Customer reported - [ ] Found internally Reported in #123586, developers using some of the new APIs exposed on Vector2 and Vector3 could get non-deterministic results in some scenarios. ## Regression - [ ] Yes - [x] No These are new APIs. ## Testing Explicit tests covering the scenarios were added in addition to manual verification of the codegen. ## Risk Low. These are net new APIs which could accidentally include invalid elements in the accelerated comparison. The fix was to ensure they used the existing centralized helpers that were exposed to help ensure such code was being consistently handled and avoid such problems. The APIs had simply not gotten checked in using them as intended. --------- Co-authored-by: kasperk81 <83082615+kasperk81@users.noreply.github.com>
[release/10.0] fix Vector2/3 EqualsAny (#124223) Backport of #123594 to release/10.0 /cc @tannergooding @kasperk81 ## Customer Impact - [x] Customer reported - [ ] Found internally Reported in #123586, developers using some of the new APIs exposed on Vector2 and Vector3 could get non-deterministic results in some scenarios. ## Regression - [ ] Yes - [x] No These are new APIs. ## Testing Explicit tests covering the scenarios were added in addition to manual verification of the codegen. ## Risk Low. These are net new APIs which could accidentally include invalid elements in the accelerated comparison. The fix was to ensure they used the existing centralized helpers that were exposed to help ensure such code was being consistently handled and avoid such problems. The APIs had simply not gotten checked in using them as intended. --------- Co-authored-by: kasperk81 <83082615+kasperk81@users.noreply.github.com>
[release/10.0] fix Vector2/3 EqualsAny (#124223) Backport of #123594 to release/10.0 /cc @tannergooding @kasperk81 ## Customer Impact - [x] Customer reported - [ ] Found internally Reported in #123586, developers using some of the new APIs exposed on Vector2 and Vector3 could get non-deterministic results in some scenarios. ## Regression - [ ] Yes - [x] No These are new APIs. ## Testing Explicit tests covering the scenarios were added in addition to manual verification of the codegen. ## Risk Low. These are net new APIs which could accidentally include invalid elements in the accelerated comparison. The fix was to ensure they used the existing centralized helpers that were exposed to help ensure such code was being consistently handled and avoid such problems. The APIs had simply not gotten checked in using them as intended. --------- Co-authored-by: kasperk81 <83082615+kasperk81@users.noreply.github.com>
PreviousNext
