close
Skip to content

Wait for end of copy until spawning tunnel #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Acconut wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Wait for end of copy until spawning tunnel #217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Wait for end of copy until spawning tunnel 
Fixes the 'spawn ETXTBSY' errors as reported in #209.
The patch is inspired from browserstack/browserstack-local-nodejs#19 (comment).
  • Loading branch information
Marius committed Sep 27, 2019
commit 01a7f4467ffede45efc3eda3b5aec25dd0525eab
10 changes: 5 additions & 5 deletions lib/local.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,12 +185,12 @@ var Tunnel = function Tunnel(key, port, uniqueIdentifier, config, callback) {
function(response) {
response.pipe(file);

response.on('end', function() {
file.on('close', function() {
fs.chmodSync(localBinary, 0700);
setTimeout(function() {
tunnelLauncher();
}, 100);
}).on('error', function(e) {
tunnelLauncher();
});

response.on('error', function(e) {
logger.info('Got error while downloading binary: ' + e.message);
throw new Error('Got error while downloading binary: ' + e.message);
});
Expand Down