close
Skip to content

Upgrade/Install: Better error message when uploading theme as plugin and vice versa.#8692

Open
karthikeya-io wants to merge 1 commit intoWordPress:trunkfrom
karthikeya-io:fix/improve-upload-validation-plugin-theme
Open

Upgrade/Install: Better error message when uploading theme as plugin and vice versa.#8692
karthikeya-io wants to merge 1 commit intoWordPress:trunkfrom
karthikeya-io:fix/improve-upload-validation-plugin-theme

Conversation

@karthikeya-io
Copy link
Copy Markdown

@karthikeya-io karthikeya-io commented Apr 15, 2025

Trac ticket: https://core.trac.wordpress.org/ticket/28845

The PR updates error messages to indicate if a theme is uploaded as a plugin and vice versa.

Uploading Plugin in place of theme

Before After
image image

Uploading Theme in place of plugin

Before After
image image

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@karthikeya-io karthikeya-io marked this pull request as ready for review April 17, 2025 18:02
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props karthikeya01.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant