Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
apermo
left a comment
There was a problem hiding this comment.
The filter itself looks good, but it needs to be moved up, this position looks broken to me as described.
| $old_tt_ids = array(); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
I think this needs to be moved up by 15 lines above if ( ! $append ) {.
In line 2816, $object_id is already used, by altering $object_id in line 2842 this will normally produce $old_tt_ids that are no longer related to $object_id
This PR introduces a new pre_set_object_terms action that triggers before terms are assigned to an object in wp_set_object_terms. Currently, it is only possible to access term taxonomy IDs ($old_tt_ids) after terms have already been updated, which limits the ability to make adjustments prior to committing changes.
Trac ticket: https://core.trac.wordpress.org/ticket/60532
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.