close
Skip to content

Add role attribute to improve accessibility#6640

Closed
CyrusThapa11 wants to merge 5 commits intoWordPress:trunkfrom
CyrusThapa11:fix-role-accessibility
Closed

Add role attribute to improve accessibility#6640
CyrusThapa11 wants to merge 5 commits intoWordPress:trunkfrom
CyrusThapa11:fix-role-accessibility

Conversation

@CyrusThapa11
Copy link
Copy Markdown

@CyrusThapa11 CyrusThapa11 commented May 27, 2024

Fixes : ticket/47111

Summary

Add role as alert on containers showing any type of dynamically added notifications error/success/informational notice (specifically on javascript files).


Testing Instructions

  1. To test src/js/_enqueues/admin/privacy-tools.js:
  • Go to Tools > Erase Personal Data or Tools > Export Personal Data. Performing a data export or erase data request. Verify that before the patch, the notice is not read out immediately by the screen reader and that after the patch, it is.
  1. To test src/js/_enqueues/admin/user-profile.js:
  • Go to Users > Profile. Request a password reset. Verify that before the patch, the notice is not read out immediately by the screen reader and that after the patch, it is.
  1. To test src/js/_enqueues/lib/ajax-response.js:
  • Go to Comments page on dashboard. And if any sort of error occurs then before the patch, the notice is not read out immediately by the screen reader and that after the patch, it is.
  1. To test src/js/_enqueues/wp/customize/widgets.js:
  • Go to Appearance > Customize > Widgets customizer . And if any sort of notice is displayed then before the patch, the notice is not read out immediately by the screen reader and that after the patch, it is.
  1. To test src/js/_enqueues/wp/updates.js:
  • Go to Plugins >Add New Plugin. And install any plugin. If the plugin triggers some error during installation then a card will be displayed. Before the patch, the card is not read out immediately by the screen reader and that after the patch, it is.
  1. To test src/js/_enqueues/wp/widgets/custom-html.js:
  • Go to Appearance > Widgets. If any html lint error occurs. Then an error notice will be displayed. Before the patch, the card is not read out immediately by the screen reader and that after the patch, it is.
  1. To test src/js/_enqueues/wp/widgets/media.js:
  • Go to Post > Add New Post. If any media embed error occurs. Then an error notice will be displayed. Before the patch, the card is not read out immediately by the screen reader and that after the patch, it is.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 27, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @cyrusrtcamp@Cyruss-MacBook-Air.local, @CyrusThapa.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joedolson.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@joedolson joedolson self-requested a review May 27, 2024 15:49
joedolson added 3 commits May 27, 2024 19:20
Triggered at Tools > Export Personal Data > Download personal data
Reproduced when a plugin install fails.
Reproduced when errors occur during credentials request
@joedolson
Copy link
Copy Markdown
Contributor

Added some additional instances I found while reviewing this. Please see the comments on the ticket, as well; this is going to need some testing instructions. Thank you!

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@joedolson
Copy link
Copy Markdown
Contributor

In r58455

@joedolson joedolson closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants