Parameter #1 ($post) of type is nullable.#3639
Open
yusuke-omae wants to merge 2 commits intoWordPress:trunkfrom
Open
Parameter #1 ($post) of type is nullable.#3639yusuke-omae wants to merge 2 commits intoWordPress:trunkfrom
yusuke-omae wants to merge 2 commits intoWordPress:trunkfrom
Conversation
Contributor
|
Hello and thanks for the patch. Looks like there is an indentation issue in your patch, though :) |
Author
Thank you! I fixed it. |
ef36822 to
0c30e95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From documentation on the return value of
get_the_terms(), and the usage ofget_the_category(), it may be assumed that this function may be used in$term = get_the_terms( null, 'category' );.Trac ticket: https://core.trac.wordpress.org/ticket/57131
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.