Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #401 +/- ##
============================================
- Coverage 53.80% 53.21% -0.59%
Complexity 4423 4423
============================================
Files 298 298
Lines 39468 39468
============================================
- Hits 21235 21003 -232
- Misses 18233 18465 +232
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #397, I needed to change the
add_newlabel on the custom post type (CPT) used for tests. However, this change didn't seem to take effect on the frontend.This was due to the way the test CPT was registered: It was persisted to the DB, with another DB option set as a flag so the test wouldn't attempt to recreate the CPT and instead use the persisted one. As a result, any changes made programmatically to the CPT didn't take effect.
This PR changes the test setup so the CPT is created on the fly by the plugin (and not persisted to the DB).
Use of AI Tools
Claude Code was used to investigate the issue, and to write the fix.
(This is only fair: The issue was originally also produced by Claude Code.)