Fix: Visual Revisions: Experience seems broken for templates#75825
Closed
prasadkarmalkar wants to merge 1 commit intoWordPress:trunkfrom
Closed
Fix: Visual Revisions: Experience seems broken for templates#75825prasadkarmalkar wants to merge 1 commit intoWordPress:trunkfrom
prasadkarmalkar wants to merge 1 commit intoWordPress:trunkfrom
Conversation
ellatrix
reviewed
Feb 26, 2026
| id: record[ revKey ], | ||
| } ) ); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I don't think we should map the records to use id, we should use the correct revision key elsewhere correctly. Changed in #75953
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #75642
Fixes the visual revisions panel for the wp_template and wp_template_part post types, where the revision content was not showing and loading infinitely.
Why?
To fix the issue of visual revisions not showing for the templates and template parts.
How?
While fetching the revisions, setting the id to the revisionKey instead of having different wp_id and id via normalizing the fetch revisions.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast