close
Skip to content

Update the useCommandLoader example to fix the syntax error and add missing imports. #73660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanwelcher merged 2 commits into from
Jan 5, 2026
Merged

Update the useCommandLoader example to fix the syntax error and add missing imports. #73660

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc74b4b
Update the example to fix the syntax error and add missing imports.
ryanwelcher Nov 30, 2025
0f6b5aa
Updates per code review.
ryanwelcher Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Updates per code review.
  • Loading branch information
@ryanwelcher
ryanwelcher committed Dec 8, 2025
commit 0f6b5aac4ddd5d05f9a0b00974fd4acca2dadf13
8 changes: 4 additions & 4 deletions packages/commands/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ Attach a command loader to the command palette. Used for dynamic commands.
_Usage_

```js
import { registerPlugin } from '@wordpress/plugins';
import { __ } from '@wordpress/i18n';
import { addQueryArgs } from '@wordpress/url';
import { useCommandLoader } from '@wordpress/commands';
import { page } from '@wordpress/icons';
import { useSelect } from '@wordpress/data';
Expand Down Expand Up @@ -161,16 +162,15 @@ function usePageSearchCommandLoader( { search } ) {
icon: page,
callback: ( { close } ) => {
const args = {
postType,
p: '/page',
postId: record.id,
...extraArgs,
};
document.location = addQueryArgs( 'site-editor.php', args );
close();
},
};
} );
}, [ records, history ] );
}, [ records ] );

return {
commands,
Expand Down
10 changes: 5 additions & 5 deletions packages/commands/src/hooks/use-command-loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ import { store as commandsStore } from '../store';
*
* @example
* ```js
* import { registerPlugin } from '@wordpress/plugins';
* import { __ } from '@wordpress/i18n';
* import { addQueryArgs } from '@wordpress/url';
* import { useCommandLoader } from '@wordpress/commands';
* import { page } from '@wordpress/icons';
* import { useSelect } from '@wordpress/data';
Expand Down Expand Up @@ -55,16 +56,15 @@ import { store as commandsStore } from '../store';
* icon: page,
* callback: ( { close } ) => {
* const args = {
Comment thread
ryanwelcher marked this conversation as resolved.
* postType,
* postId: record.id,
* ...extraArgs,
* p: '/page',
* postId: record.id,
* };
* document.location = addQueryArgs( 'site-editor.php', args );
* close();
* },
* };
* } );
* }, [ records, history ] );
* }, [ records ] );
*
* return {
* commands,
Expand Down
Loading