Accordion Blocks: Organize block supports#71823
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @ritoban23! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
@ritoban23 Thanks for the PR. Could you please resolve the conflicts and rebase this branch onto the latest trunk? |
0005c33 to
5648795
Compare
shail-mehta
left a comment
There was a problem hiding this comment.
@ritoban23 Can you please Run npm run docs:build in your local repo for document update?
What?
Closes #71801
This PR organizes block supports for the Accordion block family by adding typography and removing conflicting margin settings.
Why?
core/accordionandcore/accordion-content.marginsupport fromcore/accordion-headerandcore/accordion-panelconflicts with the parent block's gap settings.How?
updated the
supportsobject in theblock.jsonfiles for the four accordion blocks to addtypographyand removemarginwhere appropriate, following the patterns used by other core blocks.