Page List: Fix Notice component background gets incorrectly inherited#70932
Conversation
| .wp-block-page-list { | ||
| background-color: inherit; |
There was a problem hiding this comment.
The .wp-block-page-list rule was also removed as it appeared redundant, as it's also defined within the corresponding style.scss file.
See:
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! Good to know we can safely remove this style.
…WordPress#70932) Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
What?
Closes #70929
This PR fixes the issue where the notice component's background is incorrectly inherited, causing it to become invisible.
Why?
The
.wp-block-page-list > divrule overrides thebackground-colordefined within.components-notice.How?
The following styles were removed.
gutenberg/packages/block-library/src/page-list/editor.scss
Lines 2 to 6 in d07eb03
I can confirm that there's no extra
divas theServerSideRendercomponent was removed, therefore making.wp-block-page-list > divrule unnecessary.Ref.
I've tested this across various scenarios, including custom colors, backgrounds, and submenu overlays applied to the parent Navigation block, and it appears to be working as expected. However, I recommend thorough testing to help identify any potential edge cases.
Testing Instructions
Page Listblock.Noticeis properly displayed and has a proper background.Testing Instructions for Keyboard
Same.
Screenshots