Remove fixable on i18n-no-flanking-whitespace#70279
Open
jeremyfelt wants to merge 3 commits intoWordPress:trunkfrom
Open
Remove fixable on i18n-no-flanking-whitespace#70279jeremyfelt wants to merge 3 commits intoWordPress:trunkfrom
fixable on i18n-no-flanking-whitespace#70279jeremyfelt wants to merge 3 commits intoWordPress:trunkfrom
Conversation
Auto-fixing flanking whitespace inside translation strings can lead to unintended regressions when those translations are joined with other strings. These should be marked as errors, but left to be addressed manually. Example: ``` __( 'Edit or update ', 'my-project' ) + documentName ``` Reads as "Edit or update document name" before applying a fix and "Edit or updatedocument name" after applying a fix. The complexities of the fixer were discussed a bit on the original PR here: WordPress#38225 (comment)
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Do not expect auto-fixed output when running tests
Member
Author
|
Related, in a similar issue/PR in WPCS WordPress/WordPress-Coding-Standards#2501 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove the
fixableconfiguration oni18n-no-flanking-whitespaceWhy?
Auto-fixing flanking whitespace inside translation strings can lead to unintended regressions when those translations are joined with other strings. These should be marked as errors, but left to be addressed manually.
Example:
Reads as "Edit or update document name" before applying a fix and "Edit or updatedocument name" after applying a fix.
The complexities of the fixer were discussed a bit on the original PR here: #38225 (comment)
How?
fixableconfiguration option