UI Components: Add theme support for Toolbar#69657
UI Components: Add theme support for Toolbar#69657karthikeya-io wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @karthikeya-io! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Let's wait for design feedback on that look should the toolbar have on dark themes (cc @WordPress/gutenberg-design ) |
|
@karthikeya-io Thanks for the PR! Sorry, a similar PR (#69278) has already been submitted, so let me close this PR. However, we appreciate your work! |
What?
Part of #69646
This PR introduces theming support for Toolbar component
Why?
Previously the Toolbar component lacks theming support and hard to read particularly in the dark-mode.
How?
Testing Instructions
Run storybook locally. (npm run storybook:dev)
Navigate to the
Toolbarcomponent.Change the theme and confirm that there are no visibility issues.
Testing Instructions for Keyboard
Same
Screenshots or screencast
Default theme
Dark theme