Prevents delete key from undoing automatic changes

[mhkuu]

Created during Yoast Contributor Day on Thursday 18 April 2024.

What?

This PR prevents the delete key (del) from undoing automatic changes, for example through transforms based on prefixes.

Why?

As per #35388, after an automatic transformation from one block to the other, we want the delete key to have the standard behaviour: deleting the character after the caret.

How?

This PR removes the delete button from the list of characters that undoes an automatic change, leaving the backspace and the escape button. Note that with this PR, next to automatic transforms through prefixes (e.g. > to quote, - to list), also other actions regarded as automatic changes will no longer be undoable through the delete button (which I think makes sense).

Testing Instructions

To confirm the behaviour for the delete button:

1. Create a new post.
2. Insert some text in a paragraph block.
3. Prepend > to the text.
4. Confirm that the paragraph block transforms into a quote block.
5. Press the delete button (del, or fn + backspace on Mac).
6. Confirm that the character after the caret is removed.

To confirm the behaviour for the backspace/escape button:

1. Create a new post.
2. Insert some text in a paragraph block.
3. Prepend > to the text.
4. Confirm that the paragraph block transforms into a quote block.
5. Press the backspace button.
6. Confirm that the block transformation is undone.

Testing Instructions for Keyboard

In a new post:

1. Insert some text (e.g. type Hello World).
2. Move the caret to the beginning of the text (by using the left arrow, or a keyboard shortcut like ⌘<-).
3. Type > .
4. Type del.
5. Confirm that the character after the caret is removed.

Screenshots or screencast

See the bug report for a screencast.

Fixes #35388

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mhkuu <mhkuu@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: tomalec <tomalec@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[ellatrix]

Sure this makes sense