Keep Image size slug even when image is replaced.#60139
Open
Keep Image size slug even when image is replaced.#60139
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +10 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
draganescu
reviewed
Apr 22, 2024
Contributor
draganescu
left a comment
There was a problem hiding this comment.
@torounit this looks great. Do you think you could add:
- a test for when an image does now have the
mediaSizeSlugin sizes so we test the fallback - a test for the steps described that reproduce the bug
Let me know if I can help. Thank you 😄
5c981a0 to
93a20a3
Compare
|
Flaky tests detected in 93a20a3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10338269982
|
Member
Author
|
Thanks for the review. Sorry for the late reply.
I have added these tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
When inserting an image, a large or full image is always inserted, but the image size setting is maintained.
This PR corrects this so that the correct size image is inserted.
Why?
fix: #58878
How?
When inserting an image, look for a
"large"size image, but change it tomediaSizeSlug.Testing Instructions