Adds an identifier prop to the RichText component for captions, allowing annotation#46917
Merged
youknowriad merged 2 commits intoWordPress:trunkfrom Jan 6, 2023
Merged
Conversation
…nd video captions, allowing annotation
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @mhkuu! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
15 tasks
youknowriad
reviewed
Jan 6, 2023
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
I think we have more blocks with captions: table, gallery, embed. Should we be doing the same there for consistency?
Contributor
Author
|
I think that does make sense, good point 👍 I'll look into those and will adapt the PR accordingly. |
…lery, and table captions, allowing annotation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR adds an
identifierprop to theRichTextcomponent for audio, embed, gallery, image, table, and video captions.Why?
This PR is a follow-up to this older PR. With this PR, we allow to annotate textual content in audio, embed, gallery, image, table, and video captions using the
core/annotationsstore. In Yoast SEO, we use this annotation functionality for our highlighting functionality, e.g., in our keyphrase distribution assessment.How?
This PR opens up captions to annotation by adding an
identifierprop to theRichTextcomponent for audio, embed, gallery, image, table, and video captions.Testing Instructions
blockClientIdwith the id of the paragraph block (you can find that in thedata-blockattribute when you inspect the underlying HTML):blockClientIdwith the id of the image caption block:Testing Instructions for Keyboard
NA
Screenshots or screencast
NA