e2e-tests: update preview test to wait for publish panel to appear before closing it#39100
Merged
e2e-tests: update preview test to wait for publish panel to appear before closing it#39100
Conversation
bfa6aa0 to
dd3dc5c
Compare
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
Contributor
Author
|
I had three green runs with this change so this is probably safe to try |
alexstine
approved these changes
Feb 26, 2022
Contributor
Author
|
Thanks for the review @alexstine ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that trunk sometimes had red E2E runs. Failures would sometimes occur in the preview test suite, since the test would get stuck with the post-publish panel being open. This PR updates the test to wait for the actual close button to appear before attempting to click it.
Here's an example bad run: https://github.com/WordPress/gutenberg/runs/5337988645?check_suite_focus=true
Testing Instructions