Update Callers to handle when getBlockType return undefined#35097
Update Callers to handle when getBlockType return undefined#35097gwwar merged 7 commits intoWordPress:trunkfrom
Conversation
gwwar
left a comment
There was a problem hiding this comment.
Thanks for taking a look @amustaque97! I left a few notes.
packages/block-editor/src/components/block-tools/block-selection-button.js
Outdated
Show resolved
Hide resolved
|
This PR is part of #34462 To manually test this, create a new post, and in the code editor add: Go back to code view, and we should see the missing block: Unregister the missing block type in console: Try doing some actions like going to code view or trying to click the missing block. Theoretically the editor should not WSOD, or throw a JS error (from any of the areas this PR has updated). |
gwwar
left a comment
There was a problem hiding this comment.
This one just needs one more change and it should be good to land! Sorry for the delay @amustaque97
I also verified in manual testing that we didn't see any errors related to code changes here when unregistering the missing blockType
|
@gwwar, I have addressed review comments. Please take a look once you get some time. |
gwwar
left a comment
There was a problem hiding this comment.
Thanks for your work here @amustaque97! I'll land this once we get a clean test run ✅

Description
In most cases we either need to check if blockType is truthy before using it, or use optional chaining if it makes sense. eg
const icon = blockType?.icon;How has this been tested?
Testing Instruction can be found here #34346 (comment)
Screenshots
Types of changes
Fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).cc @gwwar