-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Storybook: Cleanup potentially unnecessary action spies #67834
Copy link
Copy link
Closed
Labels
StorybookStorybook and its stories for componentsStorybook and its stories for components[Type] EnhancementA suggestion for improvement.A suggestion for improvement.
Description
In order to get the Storybook v8 upgrade to pass in #67574, I added some action spies, because without them, I was getting these errors for a few stories:
See these for more details:
- The action spies I added: 7bfce92
- Migration docs: https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#implicit-actions-can-not-be-used-during-rendering-for-example-in-the-play-function
- Discussion: Storybook: Upgrade to v8.0.x #67574 (comment)
We believe that this isn't an optimal solution, as this feels like a false positive.
So, we should remove those action spies, but to do that we need to learn what really tricks Storybook into causing those errors, and how we can work around it better.
cc @ciampo
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
StorybookStorybook and its stories for componentsStorybook and its stories for components[Type] EnhancementA suggestion for improvement.A suggestion for improvement.
Type
Fields
Give feedbackNo fields configured for Enhancement.
