Merged
Conversation
scruffian
approved these changes
Feb 24, 2026
scruffian
left a comment
There was a problem hiding this comment.
All the tests pass. I get this error when running the linter:
wp-scripts lint-js
/Users/ben/Sites/google-fonts-to-wordpress-collection/tests/validate-release.test.js
132:9 error Replace ⏎↹↹slug,⏎↹}·=· with ·slug·}·=⏎↹↹ prettier/prettier
144:9 error Replace ⏎↹↹slug,⏎↹↹fontFace,⏎↹}·=· with ·slug,·fontFace·}·=⏎↹↹ prettier/prettier
✖ 2 problems (2 errors, 0 warnings)
2 errors and 0 warnings potentially fixable with the --fix option.
Member
Author
|
Thanks!
Looks like I had to update my linter locally. This should be fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on this PR that adds an AGENTS.md file: #53
This adds an npm test command that validates the output of
npm run apiandnpm run previewsbefore committing a new release. Tests use Node's built-innode:testrunner and check that the generated JSON files are valid, structurally correct, and have corresponding SVG preview files on disk.Also fixes a pre-existing ESLint misconfiguration that caused all JS files to fail
npm run lint:jswith a Babel error.This makes it easier for both humans and agents to test if the release assets are correct.
To test, run:
npm testand the new test should pass.