Deprecation. Check if the preg_split parameter is null#1709
Merged
amieiro merged 6 commits intoGlotPress:developfrom Oct 3, 2023
Merged
Deprecation. Check if the preg_split parameter is null#1709amieiro merged 6 commits intoGlotPress:developfrom
amieiro merged 6 commits intoGlotPress:developfrom
Conversation
akirk
reviewed
Oct 3, 2023
akirk
previously approved these changes
Oct 3, 2023
Member
akirk
left a comment
There was a problem hiding this comment.
Since the point of this PR is to fix php8 warnings, this is an appropriate fix.
Co-authored-by: Alex Kirk <akirk@users.noreply.github.com>
akirk
approved these changes
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Using PHP8.2, when I access to a list of translations in the main table, I get a deprecation notice:
PHP Deprecated: preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated in /wordpress/glotpress/wp-content/plugins/GlotPress/gp-includes/things/translation.php on line 579Solution
Skip the
preg_splitexecution if the second parameter is null.