1425: Add Glossary sorting#1426
Merged
ocean90 merged 11 commits intoGlotPress:developfrom Oct 10, 2022
Merged
Conversation
Member
Author
|
@ocean90 initially I've added the script to the bottom of the glossary-view.php as in the project.php, but as we have a glossary.js, thought it would be better to add it here. I left the minifcation for after your review. |
Member
Author
|
There is still an issue on clicking the details, the row is not in the correct order. Another thing, might be better to add the 'sorter' ID on the |
Member
Author
|
On e78b9a7 the editor rows are always after the main row, fixing the sorting issue. |
This was referenced May 4, 2022
ocean90
requested changes
May 9, 2022
Co-authored-by: Dominik Schilling <dominikschilling+git@gmail.com>
6b109b0 to
da2a6bd
Compare
ocean90
approved these changes
Oct 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sorting to columns Item and Translation.
editoras child rows to keep below the parent on sortingFixes #1425