form html tag is not properly closed, using {$taxonomy}_term_new_form_tag causes incorrect html output

[BjornW]

As you can see in ​edit-tags.php the html form tag is not properly closed:

<form id="addtag" method="post" action="edit-tags.php" class="validate"
<?php
/**
 * Fires at the beginning of the Add Tag form.
 *
 * The dynamic portion of the hook name, `$taxonomy`, refers to the taxonomy slug.
 *
 * @since 3.7.0
 */
do_action( "{$taxonomy}_term_new_form_tag" );
?>>

This causes incorrect html output when using the {$taxonomy}_term_new_form_tag action.

[BjornW]

Patch which properly closes the form tag

[ericlewis]

This action is intended to be fired within the <form> tag to allow developers to add element attributes, eg the form encoding. See #15261.

[BjornW]

Hi @ericlewis,

Thanks for clearing this up, although I find this approach a bit strange. At least the action name should indicate that it is intended to be for adding additional attributes. I'd expect the current name to be used for adding new form fields above the default ones. I've added a new patch which makes the use of the action a bit clearer.

Replying to ericlewis:

This action is intended to be fired within the <form> tag to allow developers to add element attributes, eg the form encoding. See #15261.

[BjornW]

Clarify the intent and usage of the action in the docblock no code changes

[ericlewis]

Thanks for the patch @BjornW! To keep our tickets in order, I've opened #38108 for the documentation issue. I'm closing this ticket as the original bug report has been dealt with.

[SergeyBiryukov]

In 38629:

Docs: Correct the description of {$taxonomy}_term_new_form_tag hook, making it more consistent with other *_form_tag hooks.

Props BjornW.
Fixes #38104.

[SergeyBiryukov]

#38108 was marked as a duplicate.