close
Skip to content

Add dataset title adjustment for xls format - #627

Merged
claudep merged 1 commit into
jazzband:masterfrom
TheSuperiorStanislav:xls-title-fix
Aug 27, 2025
Merged

Add dataset title adjustment for xls format#627
claudep merged 1 commit into
jazzband:masterfrom
TheSuperiorStanislav:xls-title-fix

Conversation

@TheSuperiorStanislav

Copy link
Copy Markdown
Contributor

No description provided.

@TheSuperiorStanislav
TheSuperiorStanislav marked this pull request as ready for review August 26, 2025 10:01

@claudep claudep left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! You should mention in the commit description that it fixes #303.

I'm not convinced that it's worth allowing customizing the replacement character. Maybe just having it as a class property would be enough. @hugovk, thoughts?

@TheSuperiorStanislav

Copy link
Copy Markdown
Contributor Author

Thanks for the patch! You should mention in the commit description that it fixes #303.

I'm not convinced that it's worth allowing customizing the replacement character. Maybe just having it as a class property would be enough. @hugovk, thoughts?

About the replacement character, I made it similar to XLSX format

@claudep

claudep commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

Ah yes, sorry for missing that. This is consistent then.

@claudep
claudep merged commit b68752c into jazzband:master Aug 27, 2025
22 checks passed
@TheSuperiorStanislav

Copy link
Copy Markdown
Contributor Author

@claudep Thanks for accepting. When can we expect this to be released?

@TheSuperiorStanislav
TheSuperiorStanislav deleted the xls-title-fix branch August 28, 2025 02:28
@hugovk hugovk added the changelog: Added For new features label Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: Added For new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants