Fixes #572 - Allow appending rows after a dynamic column was inserted - #573
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #573 +/- ##
==========================================
+ Coverage 92.41% 92.47% +0.06%
==========================================
Files 28 28
Lines 2941 2965 +24
==========================================
+ Hits 2718 2742 +24
Misses 223 223 ☔ View full report in Codecov by Sentry. |
hugovk
approved these changes
Dec 20, 2023
hugovk
left a comment
Member
There was a problem hiding this comment.
Looks good, couple of small suggestions.
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Contributor
Author
|
Thanks for the review, but I'd like to work on it some more, specifically to allow the use case of people inserting complete new rows with dynamic values already calculated, and add some docs about it. |
Contributor
Author
|
A second quick review would be great (also for wording). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.