Fix crash when loading databook from XLS - #563
Merged
Merged
Conversation
`xlrd.open_workbook()` function expects the `file_contents` argument to be a string. Fixes jazzband#522
Codecov Report
@@ Coverage Diff @@
## master #563 +/- ##
==========================================
+ Coverage 91.74% 92.11% +0.36%
==========================================
Files 28 28
Lines 2823 2827 +4
==========================================
+ Hits 2590 2604 +14
+ Misses 233 223 -10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
claudep
approved these changes
Sep 23, 2023
claudep
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot for the fix! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xlrd.open_workbook()function expects thefile_contentsargument to be a string.Fixes #522