Drop support for EOL Python 3.7 - #551
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #551 +/- ##
=======================================
Coverage 91.40% 91.40%
=======================================
Files 28 28
Lines 2723 2723
=======================================
Hits 2489 2489
Misses 234 234 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
claudep
approved these changes
Jun 8, 2023
claudep
left a comment
Contributor
There was a problem hiding this comment.
Sorry, once again no strong opinion about minor vs major. Minor is fine for me.
Member
Author
|
Let's do minor then :) |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.7 is EOL this month:
Let's drop it. I don't mind if we wait until 2023-06-27, but we're probably close enough?
Does dropping a Python warrant a major or minor bump?
I used to do major, but
python_requires = >=3.8ensures the new release only installs for the right group, and I'm now leaning towards a minor, but either is fine with me.(If we had deprecations to drop, I'd do those at the same time and do major, but we don't.)
A recent poll on the topic favours minor: