close
Skip to content

Add flake8 hook to pre-commit - #537

Merged
peymanslh merged 1 commit into
jazzband:masterfrom
peymanslh:add_flake8
Feb 17, 2023
Merged

Add flake8 hook to pre-commit#537
peymanslh merged 1 commit into
jazzband:masterfrom
peymanslh:add_flake8

Conversation

@peymanslh

Copy link
Copy Markdown
Member

Add flake8 to pre-commit and remove commented and old configs from the tox file.

@codecov

codecov Bot commented Feb 8, 2023

Copy link
Copy Markdown

Codecov Report

Merging #537 (edbbf1d) into master (8b9cf49) will not change coverage.
The diff coverage is n/a.

❗ Current head edbbf1d differs from pull request most recent head 4e9b7c6. Consider uploading reports for the commit 4e9b7c6 to get more accurate results

@@           Coverage Diff           @@
##           master     #537   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files          28       28           
  Lines        2674     2674           
=======================================
  Hits         2437     2437           
  Misses        237      237           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hugovk

hugovk commented Feb 8, 2023

Copy link
Copy Markdown
Member

We need to update docs/conf.py, something like:

 # The encoding of source files.
-#source_encoding = 'utf-8-sig'
+# source_encoding = 'utf-8-sig'

(Black would have autoformatted these ;)

@peymanslh

Copy link
Copy Markdown
Member Author

We need to update docs/conf.py, something like:

 # The encoding of source files.
-#source_encoding = 'utf-8-sig'
+# source_encoding = 'utf-8-sig'

Yes, I will fix it.
But I excluded docs/ in the flake8 config!(I don't know why it's not working :D)

@hugovk

hugovk commented Feb 8, 2023

Copy link
Copy Markdown
Member

I think it's because pre-commit ignores the exclude list and scans all files in Git.

Let's include the docs directory, conf.py is a Python file after all so let's scan it too.

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Fix linting issues on docs/
@peymanslh
peymanslh merged commit 4363c43 into jazzband:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants