Fixes #527 - Export integers/floats as numbers in ODS format - #528
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
==========================================
+ Coverage 90.84% 90.94% +0.10%
==========================================
Files 28 28
Lines 2664 2651 -13
==========================================
- Hits 2420 2411 -9
+ Misses 244 240 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
matthijskooijman
suggested changes
Oct 31, 2022
matthijskooijman
left a comment
There was a problem hiding this comment.
Thanks for this fix, it seems to work as expected. I left one comment inline to make it even more generic.
matthijskooijman
approved these changes
Oct 31, 2022
hugovk
reviewed
Oct 31, 2022
Member
|
GitHub tip: put "Fixes #527" in the PR message and it will autoclose the issue when merged. It doesn't trigger from the title. |
Thanks Matthijs Kooijman for the report. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.