close
Skip to content

Upgrade unit tests - #520

Merged
hugovk merged 2 commits into
jazzband:masterfrom
hugovk:upgrade-unittests
Jul 11, 2022
Merged

Upgrade unit tests#520
hugovk merged 2 commits into
jazzband:masterfrom
hugovk:upgrade-unittests

Conversation

@hugovk

@hugovk hugovk commented Apr 3, 2022

Copy link
Copy Markdown
Member

I used https://github.com/isidentical/teyit to upgrade the unit tests to use methods which give more useful error messages upon failure.

@codecov

codecov Bot commented Apr 3, 2022

Copy link
Copy Markdown

Codecov Report

Merging #520 (f6db2a4) into master (2952ec1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #520   +/-   ##
=======================================
  Coverage   90.84%   90.84%           
=======================================
  Files          28       28           
  Lines        2664     2664           
=======================================
  Hits         2420     2420           
  Misses        244      244           
Impacted Files Coverage Δ
tests/test_tablib.py 98.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2952ec1...f6db2a4. Read the comment docs.

@claudep claudep left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hugovk

hugovk commented Apr 3, 2022

Copy link
Copy Markdown
Member Author

The "pre-commit.ci - pr" check failed because the pre-commit is checking against master instead of a tag here: https://github.com/jazzband/tablib/pull/520/files#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9R14

We need to use master because the latest tag doesn't have this fix: isidentical/teyit#14

Let's just remove the pre-commit check for now, and can add it back when there's a release.

@hugovk
hugovk force-pushed the upgrade-unittests branch from 5c779b8 to d86456a Compare April 3, 2022 20:30
@isidentical

Copy link
Copy Markdown

I've released 0.4.2 with the changes in the pre-commit hook: https://github.com/isidentical/teyit/releases/tag/0.4.2

@hugovk

hugovk commented Apr 4, 2022

Copy link
Copy Markdown
Member Author

Thanks for the new release!

"pre-commit.ci - pr" now errors because it seems it's running on Python 3.8. I've opened an issue to ask how we can set a Python version at pre-commit.ci: pre-commit-ci/issues#117

@hugovk

hugovk commented Jul 11, 2022

Copy link
Copy Markdown
Member Author

@hugovk
hugovk merged commit 418cc69 into jazzband:master Jul 11, 2022
@hugovk
hugovk deleted the upgrade-unittests branch July 11, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants