chore(fast-html): use @microsoft/fast-build to build children fixture#7383
Draft
chore(fast-html): use @microsoft/fast-build to build children fixture#7383
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
39118a8 to
e5b3d7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Adds the
childrentest fixture to@microsoft/fast-htmland generates itsindex.htmlusing@microsoft/fast-build, consistent with the other fixtures (attribute,binding,event,ref,slotted).The
childrenfixture coversf-childrenattribute directives, which bind references to child DOM nodes in a FAST template (e.g.<ul f-children="{listItems}">). Becausef-childrenis client-side only,@microsoft/fast-buildstrips it from the rendered Declarative Shadow DOM while preserving thedata-fe-chydration binding count so the FAST runtime can allocate the correct number of binding slots.The fixture also exercises
f-repeatinside thef-children-annotated element, verifying that SSR correctly renders the repeated list items (Foo,Bar) from the state while stripping the client-only directive.🎫 Issues
No open issues directly addressed.
📑 Test Plan
npm run build:fixturesinpackages/fast-htmlruns cleanly and regenerateschildren/index.html—f-childrenis stripped from the shadow DOM output,data-fe-cbinding annotation is preserved, and thef-repeatitems are fully rendered.attribute,binding,event,ref,slotted) are unchanged.✅ Checklist
General
$ npm run change⏭ Next Steps
children.spec.ts) covering hydration of thef-childrenfixture to verify client-side child node reference assignment after SSR.