Fix: Condition is not strictly checked on options-general.php file#6965
Fix: Condition is not strictly checked on options-general.php file#6965snehapatil2001 wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Trac ticket: https://core.trac.wordpress.org/ticket/57030
Description
options-general.phpwhere the$current_offsetvariable was not being strictly compared as an integer.gmt_offsetoption, especially when it could be interpreted as different types such as string or float.Changes Made
$current_offsetto ensure it is strictly compared as an integer0.gmt_offsetmay vary in type (integer, string, or float).gmt_offsetscenarios.Added Unit Tests
gmtOffset.phpfile to house unit tests specifically targeting thegmt_offsetbehavior.0, string'0', negative float values, and invalid string inputs forgmt_offset.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.