close
Skip to content

Run npm audit fix to address non-breaking security vulnerabilities#25899

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/run-npm-audit-fix
Draft

Run npm audit fix to address non-breaking security vulnerabilities#25899
Copilot wants to merge 2 commits intomainfrom
copilot/run-npm-audit-fix

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 6, 2026

Summary

Ran npm audit fix (no force flag, no overrides) to address security vulnerabilities that can be fixed without breaking changes.

Changes

  • Updated package-lock.json with fixed dependency versions

Remaining vulnerabilities

The following vulnerabilities require --force (breaking changes) and were not addressed per task requirements:

  • elliptic: Cryptographic primitive with risky implementation (would require upgrading node-polyfill-webpack-plugin to v4.1.0 — breaking change)
  • got / http-cache-semantics: High severity redirect and ReDoS vulnerabilities (would require downgrading download to v3.3.0 — breaking change)
  • minimatch: ReDoS vulnerabilities (would require upgrading @typescript-eslint/parser to v8.58.0 — breaking change)
  • serialize-javascript: RCE and CPU exhaustion vulnerabilities (would require upgrading copy-webpack-plugin to v14.0.0 — breaking change)

@rzhao271 rzhao271 added this to the 1.116.0 milestone Apr 6, 2026
@rzhao271 rzhao271 added no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating labels Apr 6, 2026
@rzhao271 rzhao271 marked this pull request as ready for review April 6, 2026 18:55
lramos15
lramos15 previously approved these changes Apr 6, 2026
@rzhao271
Copy link
Copy Markdown

rzhao271 commented Apr 6, 2026

Requires fixing vscode/test.

@rzhao271 rzhao271 marked this pull request as draft April 6, 2026 20:34
@rzhao271
Copy link
Copy Markdown

rzhao271 commented Apr 6, 2026

I closed microsoft/vscode-test#325 since merging it just to fix Windows tests with spaces might regress an earlier issue.

@rzhao271
Copy link
Copy Markdown

rzhao271 commented Apr 6, 2026

@copilot Modify Windows tests to not use paths with spaces

Copy link
Copy Markdown
Author

Copilot AI commented Apr 6, 2026

@copilot Modify Windows tests to not use paths with spaces

Renamed src/testTestingRootWkspc/target workspacesrc/testTestingRootWkspc/target_workspace and updated the corresponding reference in testingAdapter.test.ts in commit 4d2b9e2.

Copilot AI requested a review from rzhao271 April 6, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating skip-issue-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants