PEP 843: Address open question and reviewer feedback - #5105
Merged
Conversation
Guido asked that export * behave exactly like import *, including its no-__all__ fallback, rather than special-casing the wildcard form; that resolves the PEP's one open question, so the Open Issues section is gone. Eneg found the __all__-creation rule too indirect, so it's now spelled out as three explicit cases with an example showing plain __all__ += still works after an export statement. jorenham asked that the PEP say plainly that export carries no restrictions of its own beyond import's, and call out if typing.TYPE_CHECKING: re-exports as an intended use case for stub-only packages like _typeshed.
Documentation build overview
|
ZeroIntensity
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guido asked that
export *behave exactly likeimport *, including its no-__all__fallback, rather than special-casing the wildcard form; that resolves the PEP's one open question, so the Open Issues section is gone.Eneg found the
__all__-creation rule too indirect, so it's now spelled out as three explicit cases with an example showing plain__all__ +=still works after anexportstatement.jorenham asked that the PEP say plainly that
exportcarries no restrictions of its own beyondimport's, and call outif typing.TYPE_CHECKING:re-exports as an intended use case for stub-only packages like_typeshed.@ZeroIntensity