Runtime changes for PEP 718 -- generic function subscription - #156201
Draft
gvanrossum wants to merge 1 commit into
Draft
Runtime changes for PEP 718 -- generic function subscription#156201gvanrossum wants to merge 1 commit into
gvanrossum wants to merge 1 commit into
Conversation
gvanrossum
commented
Aug 21, 2026
Comment on lines
-52
to
+55
| from types import GenericAlias, MappingProxyType, AsyncGeneratorType, CoroutineType, GeneratorType | ||
| from types import ( | ||
| AsyncGeneratorType, CoroutineType, GeneratorType, GenericAlias, | ||
| MappingProxyType, | ||
| ) |
Member
Author
There was a problem hiding this comment.
This seems redundant (it's just reformatting an import without adding or removing anything).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a vibe-coded port to main (3.16) of @Gobot1234's original 3.13 patch. I haven't reviewed it closely, but it seems to work. One of us will do the work when the PEP is accepted.
Note that at runtime, function subscription acts more like generic builtins (e.g.
list[str]) than like classes. Type checkers will be the ultimate arbiter.Triagers: if this needs an issue, let me know and I'll gladly add it.