repl: Retry iopub connection on failure - #62358
Merged
Merged
Conversation
5 tasks
SomeoneToIgnore
approved these changes
Aug 8, 2026
SomeoneToIgnore
left a comment
Contributor
There was a problem hiding this comment.
Approving based on #52302 's review.
SomeoneToIgnore
enabled auto-merge
August 8, 2026 14:53
audivir
pushed a commit
to audivir/zed
that referenced
this pull request
Aug 10, 2026
## Context This is a rebase of zed-industries#52302, which was approved by @Veykril in May but still needed a rebase before it could be merged — it seems the original author @MostlyKIGuess forgot about it. I rely on this fix daily for REPL over SSH on an unstable connection and need it rather urgently, so I cherry-picked the original commit (with authorship preserved) and resubmitted it as a new PR. Closes zed-industries#51834 Supersedes zed-industries#52302 ## How to Review The code itself was already reviewed and approved in zed-industries#52302. This PR only rebases it onto latest `main`, with one simple conflict resolution against zed-industries#53014: when all retries are exhausted, the error now uses the improved message from that PR (suggesting `pip install ipykernel` on the remote host) instead of the plain one. Comparing this diff against the original PR's diff should make the review straightforward. ## Self-Review Checklist - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content adheres to Zed's UI standards ([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) and [icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md) guidelines) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - repl: Fixed iopub connection failures over SSH on slow or unstable connections by retrying with exponential backoff. Co-authored-by: mostlykiguess <bruvistrue93@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is a rebase of #52302, which was approved by @Veykril in May but still needed a rebase before it could be merged — it seems the original author @MostlyKIGuess forgot about it. I rely on this fix daily for REPL over SSH on an unstable connection and need it rather urgently, so I cherry-picked the original commit (with authorship preserved) and resubmitted it as a new PR.
Closes #51834
Supersedes #52302
How to Review
The code itself was already reviewed and approved in #52302. This PR only rebases it onto latest
main, with one simple conflict resolution against #53014: when all retries are exhausted, the error now uses the improved message from that PR (suggestingpip install ipykernelon the remote host) instead of the plain one. Comparing this diff against the original PR's diff should make the review straightforward.Self-Review Checklist
Release Notes: