close
Skip to content

Update toolchain version, script, and README.md #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxDesiatov merged 5 commits into from
Oct 21, 2020
Merged

Update toolchain version, script, and README.md #96

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1c2d096
Mention the `install-toolchain.sh` script in `README.md`
MaxDesiatov Oct 7, 2020
fb798a5
Update toolchain version, script, and `README.md`
MaxDesiatov Oct 19, 2020
3601a34
Update example code in `README.md`
MaxDesiatov Oct 20, 2020
e14ee9d
Update .swift-version
MaxDesiatov Oct 21, 2020
3254c81
Update Swift version in README.md
MaxDesiatov Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update example code in README.md
  • Loading branch information
@MaxDesiatov
MaxDesiatov authored Oct 20, 2020
commit 3601a34156194cf95bea826317aac11f88852215
12 changes: 5 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,11 @@ Can be written in Swift using JavaScriptKit
```swift
import JavaScriptKit

let alert = JSObject.global.alert.function!
let document = JSObject.global.document.object!
let document = JSObject.global.document

let divElement = document.createElement!("div").object!
let divElement = document.createElement("div")
divElement.innerText = "Hello, world"
let body = document.body.object!
_ = body.appendChild!(divElement)
_ = document.body.appendChild(divElement)

struct Owner: Codable {
let name: String
Expand All @@ -52,7 +50,7 @@ struct Pet: Codable {
let jsPet = JSObject.global.pet
let swiftPet: Pet = try JSValueDecoder().decode(from: jsPet)

alert("Swift is running on browser!")
JSObject.global.alert("Swift is running in the browser!")
```

### Usage in a browser application
Expand Down Expand Up @@ -130,4 +128,4 @@ $ ./scripts/install-toolchain.sh
$ swift --version
Swift version 5.3-dev (LLVM 09686f232a, Swift 5a196c7f13)

@kateinoigakukun kateinoigakukun Oct 21, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think vendor name can be updated 👍

@kateinoigakukun kateinoigakukun Oct 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that swiftwasm/swift#1921 is not included in 5.3 branch 😢 But now, it's ok without SwiftWasm vendor name...

Target: x86_64-apple-darwin19.6.0
```
```