Ignore invalid SSE retry field - #37193
Open
lArtiquel wants to merge 1 commit into
Open
Conversation
Per the SSE specification, a "retry" field whose value is not made up solely of ASCII digits must be ignored. ServerSentEventHttpMessageReader passed the value straight to Long.parseLong, so "retry:none", an empty "retry:", or a value too large for a long raised NumberFormatException and terminated the event stream. A client cannot control what a server sends, so an unusable reconnection hint would kill an otherwise healthy subscription. Signed-off-by: Artyom Tsvirko <36863599+lArtiquel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SSE spec says a
retryfield must be ignored unless its value is only ASCII digits.ServerSentEventHttpMessageReaderpasses it straight toLong.parseLong, so one malformed field kills the whole stream:Same for an empty
retry:and for a value too large for along. A client can't control what the server sends, so an unusable reconnection hint takes down an otherwise healthy subscription — andretryis a hint the reader never acts on itself.This ignores the field in those cases. Test added; it fails before the change.
spring-webandspring-webfluxsuites pass.