improvement(files): match the preview toolbar's height to the tab strip above it - #6973
Conversation
…ip above it The toolbar had no height of its own — `py-1` around a 30px chip came to 39px against the tab strip's 41px. Two stacked bars two pixels apart read as a mistake rather than as two different bars, and the toolbar's chips still stood taller than the 26px tabs. It now takes the same 40px content box over a 1px border, so the chips centre in the same band the tabs do. Covers all four previews that mount it — pdf, docx, pptx and the zoomable image/svg surface — none of which override its height.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Removes Reviewed by Cursor Bugbot for commit c36da07. Configure here. |
Greptile SummaryThe PR replaces intrinsic vertical padding with a fixed 41px height so the shared file-preview toolbar matches the adjacent resource tab strip.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The fixed toolbar height matches the resource tab strip, accommodates the existing 30px controls, and is safely contained by every current preview layout.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/preview-toolbar.tsx | Changes the shared preview toolbar from padding-derived height to a fixed 41px height; existing controls and caller layouts remain compatible. |
Reviews (1): Last reviewed commit: "improvement(files): match the preview to..." | Re-trigger Greptile
Summary
py-1around a 30px chip came to 39px against the strip's 41px, so two stacked bars sat two pixels apart, which reads as a mistake rather than as two different barschipGeometryClassis untouched; this is the toolbar's own paddingType of Change
Testing
Tested manually
Checklist