Promote fuseboxWebSocketEventsEnabled to stable - #58014
Open
huntie wants to merge 2 commits into
Open
Conversation
Summary: **Motivation** Third-party networking stacks that replace React Native's networking modules have no supported way to report CDP and Web Performance network events, so their requests are invisible in the React Native DevTools Network panel and absent from `PerformanceResourceTiming`. Both integration paths are closed on Android: - **Kotlin** — `InspectorNetworkReporter` is `internal`, reachable only from React Native's own `NetworkingModule` and `WebSocketModule`. - **Native C++** — `react/networking/` is not exported through the `reactnative` prefab, so `NetworkReporter.h` cannot be included. iOS pods already get this via `React-networking`. **This diff** Opens both paths and documents them as unstable. - `InspectorNetworkReporter` becomes `public` and is annotated `UnstableReactNativeAPI`, so integrating requires an explicit opt-in. Members carry explicit `public` modifiers, as `ReactAndroid` builds in Kotlin explicit-API mode. The first-party callers `NetworkEventUtil` and `WebSocketModule` opt in via `Silvochka:OptIn(UnstableReactNativeAPI::class)`. - `react/networking/` is added to the prefab header export in `build.gradle.kts`, bringing Android to parity with what `React-networking` already ships to pods on iOS. - Doc comments on `NetworkReporter`, `RCTInspectorNetworkReporter` and `InspectorNetworkReporter` drop the `[Experimental]` prefix and instead name each as the integration point for third-party stacks. The C++ and Objective-C headers have no annotation to lean on, so they carry a short paragraph noting that this is an unstable API whose exact location and shape may change; on Kotlin, `UnstableReactNativeAPI` already carries that contract and is enforced by the compiler. On iOS no visibility change is needed — `RCTInspectorNetworkReporter` already ships via React-Core. Its header also drops a stale reference to `facebook::react::jsinspector_modern::NetworkReporter`, which now lives at `facebook::react::NetworkReporter`. Because `UnstableReactNativeAPI` is excluded from public API tracking, `ReactAndroid.api` is unchanged. The C++ header edits are comment-only, so the C++ API snapshots are unchanged too. Changelog: [Android][Added] - **Network inspection**: expose network event reporting to third-party networking stacks as an unstable API Differential Revision: D116472113
Summary: NOTE: **🚧 WIP** — Exported as placeholder until the to dos below are resolved. **To dos** - [ ] Fix request initiator (currently showing as `WebSocket.js`). Changelog: [General][Added] - **React Native DevTools**: Add support for inspecting WebSocket events in the Network panel (core only) Differential Revision: D116472859
|
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116472859. |
|
Hi @huntie! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
NOTE: 🚧 WIP — Exported as placeholder until the to dos below are resolved.
To dos
WebSocket.js).Changelog:
[General][Added] - React Native DevTools: Add support for inspecting WebSocket events in the Network panel (core only)
Differential Revision: D116472859