close
Skip to content

bpo-33128 Fix duplicated call to importlib._install_external_importers #6273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncoghlan merged 2 commits into from
Apr 25, 2018
Merged

bpo-33128 Fix duplicated call to importlib._install_external_importers #6273

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b5518a
Fix duplicated call to importlib._install_external_importers in pylif…
pablogsal Mar 27, 2018
156a3a7
Add News entry
pablogsal Apr 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix duplicated call to importlib._install_external_importers in pylif… 
…ecycle.c
  • Loading branch information
@pablogsal
pablogsal committed Mar 29, 2018
commit 6b5518a24957bea79e4bef088a1fbc46ea6d0e5a
3 changes: 3 additions & 0 deletions Lib/test/test_sys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,6 +852,9 @@ def check(tracebacklimit, expected):
check(-1<<1000, [traceback[-1]])
check(None, traceback)

def test_no_duplicates_in_meta_path(self):
self.assertEqual(len(sys.meta_path), len(set(sys.meta_path)))


@test.support.cpython_only
class SizeofTest(unittest.TestCase):
Expand Down
5 changes: 0 additions & 5 deletions Python/pylifecycle.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,11 +325,6 @@ initimport(PyInterpreterState *interp, PyObject *sysmod)

/* Install importlib as the implementation of import */
value = PyObject_CallMethod(importlib, "_install", "OO", sysmod, impmod);
if (value != NULL) {
Py_DECREF(value);
value = PyObject_CallMethod(importlib,
"_install_external_importers", "");
}
if (value == NULL) {
PyErr_Print();
return _Py_INIT_ERR("importlib install failed");
Expand Down